From: Constantine Shulyupin <const@MakeLinux.com>
To: gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Constantine Shulyupin <const@MakeLinux.com>
Subject: [PATCH] USB: usb-skeleton.c: fix compilation error and restore kref_put on fail in skel_open
Date: Sun, 7 Oct 2012 11:57:12 +0200 [thread overview]
Message-ID: <1349603832-26424-1-git-send-email-const@MakeLinux.com> (raw)
From: Constantine Shulyupin <const@MakeLinux.com>
Function skel_open increments usage count for the device with kref_get and the usage count should be decremented on the function failure.
Some last changes in function skel_open and finally commit
52a7499 Revert "USB: usb-skeleton.c: fix open/disconnect race"
introduced a bug in function skel_open, which this patch fixes.
Signed-off-by: Constantine Shulyupin <const@MakeLinux.com>
---
drivers/usb/usb-skeleton.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb-skeleton.c
index 0616f23..027005b 100644
--- a/drivers/usb/usb-skeleton.c
+++ b/drivers/usb/usb-skeleton.c
@@ -113,8 +113,10 @@ static int skel_open(struct inode *inode, struct file *file)
mutex_lock(&dev->io_mutex);
retval = usb_autopm_get_interface(interface);
- if (retval)
- goto out_err;
+ if (retval) {
+ kref_put(&dev->kref, skel_delete);
+ goto exit;
+ }
/* save our object in the file's private structure */
file->private_data = dev;
--
1.7.9.5
next reply other threads:[~2012-10-07 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 9:57 Constantine Shulyupin [this message]
2012-10-10 9:55 ` [PATCH] USB: usb-skeleton.c: fix compilation error and restore kref_put on fail in skel_open Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349603832-26424-1-git-send-email-const@MakeLinux.com \
--to=const@makelinux.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox