From: Laxman Dewangan <ldewangan@nvidia.com>
To: <sameo@linux.intel.com>
Cc: <linux-kernel@vger.kernel.org>, <vbyravarasu@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: [PATCH 2/5] mfd: tps65090: add error prints when mem alloc failed
Date: Sun, 7 Oct 2012 20:52:17 +0530 [thread overview]
Message-ID: <1349623340-21807-3-git-send-email-ldewangan@nvidia.com> (raw)
In-Reply-To: <1349623340-21807-1-git-send-email-ldewangan@nvidia.com>
Add error prints when memory allocation failed for
tps65090 data. Also cleanups the melloc arguments.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
drivers/mfd/tps65090.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
index 9b79d68..f95f7f6 100644
--- a/drivers/mfd/tps65090.c
+++ b/drivers/mfd/tps65090.c
@@ -263,10 +263,11 @@ static int __devinit tps65090_i2c_probe(struct i2c_client *client,
return -EINVAL;
}
- tps65090 = devm_kzalloc(&client->dev, sizeof(struct tps65090),
- GFP_KERNEL);
- if (tps65090 == NULL)
+ tps65090 = devm_kzalloc(&client->dev, sizeof(*tps65090), GFP_KERNEL);
+ if (!tps65090) {
+ dev_err(&client->dev, "mem alloc for tps65090 failed\n");
return -ENOMEM;
+ }
tps65090->client = client;
tps65090->dev = &client->dev;
--
1.7.1.1
next prev parent reply other threads:[~2012-10-07 15:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 15:22 [PATCH 0/5] mfd: tps65090: cleanups and use regmap-irq for interrupt support Laxman Dewangan
2012-10-07 15:22 ` [PATCH 1/5] mfd: add battery charger in tps65090 sub devs Laxman Dewangan
2012-10-07 15:22 ` Laxman Dewangan [this message]
2012-10-07 16:13 ` [PATCH 2/5] mfd: tps65090: add error prints when mem alloc failed Joe Perches
2012-10-08 6:03 ` Laxman Dewangan
2012-10-07 15:22 ` [PATCH 3/5] mfd: tps65090: remove unused member of struct tps65090 Laxman Dewangan
2012-10-08 5:40 ` Venu Byravarasu
2012-10-08 5:55 ` Laxman Dewangan
2012-10-07 15:22 ` [PATCH 4/5] mfd: tps65090: move register access APIs to header Laxman Dewangan
2012-10-08 5:37 ` Venu Byravarasu
2012-10-08 5:55 ` Laxman Dewangan
2012-10-07 15:22 ` [PATCH 5/5] mfd: tps65090: use regmap irq framework for interrupt support Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349623340-21807-3-git-send-email-ldewangan@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=vbyravarasu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox