From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757167Ab2JIXAy (ORCPT ); Tue, 9 Oct 2012 19:00:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38616 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757148Ab2JIXAv (ORCPT ); Tue, 9 Oct 2012 19:00:51 -0400 Message-ID: <1349823616.2759.308.camel@ul30vt.home> Subject: Re: [PATCH v3 10/10] mm: kill vma flag VM_RESERVED and mm->reserved_vm counter From: Alex Williamson To: Linus Torvalds Cc: Eric Dumazet , Konstantin Khlebnikov , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Hugh Dickins , Nick Piggin Date: Tue, 09 Oct 2012 17:00:16 -0600 In-Reply-To: <1349792507.2759.283.camel@ul30vt.home> References: <20120731103724.20515.60334.stgit@zurg> <20120731104239.20515.702.stgit@zurg> <1349776921.21172.4091.camel@edumazet-glaptop> <1349792507.2759.283.camel@ul30vt.home> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2012-10-09 at 08:21 -0600, Alex Williamson wrote: > On Tue, 2012-10-09 at 21:12 +0900, Linus Torvalds wrote: > > On Tue, Oct 9, 2012 at 7:02 PM, Eric Dumazet wrote: > > > > > > It seems drivers/vfio/pci/vfio_pci.c uses VM_RESERVED > > > > Yeah, I just pushed out what I think is the right (trivial) fix. > > Thank you, looks correct to me as well. Well, that might still be correct, but it's actually b3b9c293 (mm, x86, pat: rework linear pfn-mmap tracking) that breaks vfio. As soon as I add that commit our use of mmap'd device areas stops working, both mapping them through the iommu and through kvm. kvm hits the BUG_ON from !kvm_is_mmio_pfn in virt/kvm/kvm_main.c:hva_to_pfn. Thanks, Alex