* [PATCH] backlight: lm3639: Return proper error in lm3639_bled_mode_store error paths
@ 2012-10-11 5:11 Axel Lin
2012-10-12 4:49 ` gshark
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-10-11 5:11 UTC (permalink / raw)
To: Andrew Morton; +Cc: G.Shark Jeong, Richard Purdie, Daniel Jeong, linux-kernel
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/video/backlight/lm3639_bl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
index c6915c6..585949b 100644
--- a/drivers/video/backlight/lm3639_bl.c
+++ b/drivers/video/backlight/lm3639_bl.c
@@ -206,11 +206,11 @@ static ssize_t lm3639_bled_mode_store(struct device *dev,
out:
dev_err(pchip->dev, "%s:i2c access fail to register\n", __func__);
- return size;
+ return ret;
out_input:
dev_err(pchip->dev, "%s:input conversion fail\n", __func__);
- return size;
+ return ret;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] backlight: lm3639: Return proper error in lm3639_bled_mode_store error paths
2012-10-11 5:11 [PATCH] backlight: lm3639: Return proper error in lm3639_bled_mode_store error paths Axel Lin
@ 2012-10-12 4:49 ` gshark
0 siblings, 0 replies; 2+ messages in thread
From: gshark @ 2012-10-12 4:49 UTC (permalink / raw)
To: Axel Lin; +Cc: Andrew Morton, Richard Purdie, Daniel Jeong, linux-kernel
2012년 10월 11일 14:11, Axel Lin 쓴 글:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/video/backlight/lm3639_bl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
> index c6915c6..585949b 100644
> --- a/drivers/video/backlight/lm3639_bl.c
> +++ b/drivers/video/backlight/lm3639_bl.c
> @@ -206,11 +206,11 @@ static ssize_t lm3639_bled_mode_store(struct device *dev,
>
> out:
> dev_err(pchip->dev, "%s:i2c access fail to register\n", __func__);
> - return size;
> + return ret;
>
> out_input:
> dev_err(pchip->dev, "%s:input conversion fail\n", __func__);
> - return size;
> + return ret;
>
> }
>
Thank you Alex for fixing code.
Acked-by: G.Shark Jeong<gshark.jeong@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-12 4:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-11 5:11 [PATCH] backlight: lm3639: Return proper error in lm3639_bled_mode_store error paths Axel Lin
2012-10-12 4:49 ` gshark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox