From: Shuah Khan <shuah.khan@hp.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: joerg.roedel@amd.com, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, Greg KH <gregkh@linuxfoundation.org>,
iommu@lists.linux-foundation.org, stable@vger.kernel.org,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
shuahkhan@gmail.com
Subject: Re: [PATCH -stable] amd_iommu: attach device fails on the last pci device
Date: Fri, 12 Oct 2012 12:44:50 -0600 [thread overview]
Message-ID: <1350067490.4627.8.camel@lorien2> (raw)
In-Reply-To: <20121012183828.GA16453@elie.Belkin>
On Fri, 2012-10-12 at 11:38 -0700, Jonathan Nieder wrote:
> Shuah Khan wrote:
>
> > This bug is in linux-2.6.32 and an equivalent fix in linux-2.6.33 and has been
> > carried forward to later kernels and is in the upstream kernel. This equivalent
> > fix includes restructuring and consolidating device checks into a routine
> > check_device(). Instead of back-porting all of that work, spot-fixed the bug in
> > amd_iommu_attach_device() for linux-2.6.32.
>
> To save Willy time: am I correct in guessing the upstream commit you
> are referring to is 98fc5a693bbdda498a556654c70d1e31a186c988
> (x86/amd-iommu: Use get_device_id and check_device where appropriate,
> 2009-11-24)?
Yes that is one. I looked that up again and it has the change to
amd_iommu_attach_device() to use check_device() and removes the check
- if (devid >= amd_iommu_last_bdf ||
- devid != amd_iommu_alias_table[devid])
- return -EINVAL;
+ devid = get_device_id(dev);
Ref: http://www.spinics.net/lists/linux-tip-commits/msg06129.html
Thanks,
-- Shuah
next prev parent reply other threads:[~2012-10-12 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 16:29 [PATCH -stable] amd_iommu: attach device fails on the last pci device Shuah Khan
2012-10-12 17:28 ` Alex Williamson
2012-10-12 18:38 ` Jonathan Nieder
2012-10-12 18:44 ` Shuah Khan [this message]
2012-10-12 19:35 ` Jonathan Nieder
2012-10-23 15:07 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350067490.4627.8.camel@lorien2 \
--to=shuah.khan@hp.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=jrnieder@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=shuahkhan@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox