Re: [PATCH 01/10] ext4: balloc: Fixed coding style issue

richard -rw- weinberger
2012-10-17T12:13:49Z

On Wed, Oct 17, 2012 at 2:05 PM, Lukáš Czerner <lczerner@redhat.com> wrote:
> On Wed, 17 Oct 2012, Adil Mujeeb wrote:
>
>> Date: Wed, 17 Oct 2012 00:42:56 +0530
>> From: Adil Mujeeb <mujeeb.adil@gmail.com>
>> To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
>> linux-kernel@vger.kernel.org
>> Cc: Adil Mujeeb <mujeeb.adil@gmail.com>
>> Subject: [PATCH 01/10] ext4: balloc: Fixed coding style issue
>>
>> Fixed checkpatch.pl reported ERRORs
>
> Hi Adil,
>
> let me ask you something. How useful do you think those changes are ?
> Have you learned anything by creating those patches ?
>
> Just to clarify why I am asking such weird questions. It's not one of
> those sneer questions, I would really like to know.
>> linux-3.7-rc1/fs/ext4/balloc.c | 8 ++++----

The really sad thing is that this patch does not even apply because
the path is malformed.

--
Thanks,
//richard