public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ramoops: Fixup section annotations
@ 2012-10-17  7:39 Hannes Reinecke
  2012-10-22 18:53 ` Kees Cook
  0 siblings, 1 reply; 3+ messages in thread
From: Hannes Reinecke @ 2012-10-17  7:39 UTC (permalink / raw)
  To: linux-kernel
  Cc: Hannes Reinecke, Anton Vorontsov, Colin Cross, Kees Cook,
	Tony Luck

The compiler complained about missing section annotations.
Fix it.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Cc: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Colin Cross <ccross@android.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Tony Luck <tony.luck@intel.com>

---
 fs/pstore/ram.c |   12 +++++++-----
 1 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 1a4f6da..2b6ebbc 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -287,8 +287,9 @@ static void ramoops_free_przs(struct ramoops_context *cxt)
 	kfree(cxt->przs);
 }
 
-static int ramoops_init_przs(struct device *dev, struct ramoops_context *cxt,
-			      phys_addr_t *paddr, size_t dump_mem_sz)
+static int __devinit ramoops_init_przs(struct device *dev,
+				       struct ramoops_context *cxt,
+				       phys_addr_t *paddr, size_t dump_mem_sz)
 {
 	int err = -ENOMEM;
 	int i;
@@ -326,9 +327,10 @@ fail_prz:
 	return err;
 }
 
-static int ramoops_init_prz(struct device *dev, struct ramoops_context *cxt,
-			    struct persistent_ram_zone **prz,
-			    phys_addr_t *paddr, size_t sz, u32 sig)
+static int __devinit ramoops_init_prz(struct device *dev,
+				      struct ramoops_context *cxt,
+				      struct persistent_ram_zone **prz,
+				      phys_addr_t *paddr, size_t sz, u32 sig)
 {
 	if (!sz)
 		return 0;
-- 
1.7.4.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ramoops: Fixup section annotations
  2012-10-17  7:39 [PATCH] ramoops: Fixup section annotations Hannes Reinecke
@ 2012-10-22 18:53 ` Kees Cook
  2012-11-17  2:43   ` Anton Vorontsov
  0 siblings, 1 reply; 3+ messages in thread
From: Kees Cook @ 2012-10-22 18:53 UTC (permalink / raw)
  To: Hannes Reinecke; +Cc: linux-kernel, Anton Vorontsov, Colin Cross, Tony Luck

On Wed, Oct 17, 2012 at 12:39 AM, Hannes Reinecke <hare@suse.de> wrote:
> The compiler complained about missing section annotations.
> Fix it.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Cc: Anton Vorontsov <cbouatmailru@gmail.com>
> Cc: Colin Cross <ccross@android.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Tony Luck <tony.luck@intel.com>

Acked-by: Kees Cook <keescook@chromium.org>

Thanks for the fix!

-Kees

-- 
Kees Cook
Chrome OS Security

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ramoops: Fixup section annotations
  2012-10-22 18:53 ` Kees Cook
@ 2012-11-17  2:43   ` Anton Vorontsov
  0 siblings, 0 replies; 3+ messages in thread
From: Anton Vorontsov @ 2012-11-17  2:43 UTC (permalink / raw)
  To: Kees Cook; +Cc: Hannes Reinecke, linux-kernel, Colin Cross, Tony Luck

On Mon, Oct 22, 2012 at 11:53:33AM -0700, Kees Cook wrote:
> On Wed, Oct 17, 2012 at 12:39 AM, Hannes Reinecke <hare@suse.de> wrote:
> > The compiler complained about missing section annotations.
> > Fix it.
> >
> > Signed-off-by: Hannes Reinecke <hare@suse.de>
> > Cc: Anton Vorontsov <cbouatmailru@gmail.com>
> > Cc: Colin Cross <ccross@android.com>
> > Cc: Kees Cook <keescook@chromium.org>
> > Cc: Tony Luck <tony.luck@intel.com>
> 
> Acked-by: Kees Cook <keescook@chromium.org>

Applied, thank you!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-11-17  2:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-17  7:39 [PATCH] ramoops: Fixup section annotations Hannes Reinecke
2012-10-22 18:53 ` Kees Cook
2012-11-17  2:43   ` Anton Vorontsov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox