From: Ian Campbell <ian.campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>,
Mukesh Rathor <mukesh.rathor@oracle.com>,
linux-kernel@vger.kernel.org, xen-devel@lists.xen.org,
Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH 3/6] xen: avoid use of vma->vm_private in xen_unmap_domain_mfn_range interface
Date: Wed, 17 Oct 2012 12:32:09 +0100 [thread overview]
Message-ID: <1350473532-15863-3-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1350473518.2460.58.camel@zakaz.uk.xensource.com>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
I beleive Mukesh has something similar in his tree. Should be trivial
to resolve I think. I'm happy to do so ontop of PVH v3 when it arrives.
---
arch/x86/xen/mmu.c | 6 ++----
drivers/xen/privcmd.c | 2 +-
include/xen/xen-ops.h | 3 ++-
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index 018cbf0..1c5812b 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -2655,11 +2655,9 @@ out:
EXPORT_SYMBOL_GPL(xen_remap_domain_mfn_range);
/* Returns: 0 success */
-int xen_unmap_domain_mfn_range(struct vm_area_struct *vma)
+int xen_unmap_domain_mfn_range(struct vm_area_struct *vma,
+ struct page **pages, int numpgs)
{
- int numpgs = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
- struct page **pages = vma ? vma->vm_private_data : NULL;
-
if (!pages || !xen_feature(XENFEAT_auto_translated_physmap))
return 0;
diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index 641a420..a1ca5ab 100644
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -498,7 +498,7 @@ static void privcmd_close(struct vm_area_struct *vma)
if (!pages || !numpgs || !xen_feature(XENFEAT_auto_translated_physmap))
return;
- xen_unmap_domain_mfn_range(vma);
+ xen_unmap_domain_mfn_range(vma, pages, numpgs);
while (numpgs--)
free_xenballooned_pages(1, &pages[numpgs]);
kfree(pages);
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index 8b24315..6a40253 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -29,6 +29,7 @@ int xen_remap_domain_mfn_range(struct vm_area_struct *vma,
unsigned long mfn, int nr,
pgprot_t prot, unsigned domid,
struct page **pages);
-int xen_unmap_domain_mfn_range(struct vm_area_struct *vma);
+int xen_unmap_domain_mfn_range(struct vm_area_struct *vma,
+ struct page **pages, int nr);
#endif /* INCLUDE_XEN_OPS_H */
--
1.7.2.5
next prev parent reply other threads:[~2012-10-17 11:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 11:31 [PATCH V2 0/6] arm: implement ballooning and privcmd foreign mappings based on x86 PVH Ian Campbell
2012-10-17 11:32 ` [PATCH 1/6] xen: balloon: allow PVMMU interfaces to be compiled out Ian Campbell
2012-10-18 13:11 ` Stefano Stabellini
2012-10-17 11:32 ` [PATCH 2/6] xen: arm: enable balloon driver Ian Campbell
2012-10-18 13:20 ` Stefano Stabellini
2012-10-17 11:32 ` Ian Campbell [this message]
2012-10-17 11:32 ` [PATCH 4/6] xen: correctly use xen_pfn_t in remap_domain_mfn_range Ian Campbell
2012-10-18 13:23 ` Stefano Stabellini
2012-10-17 11:32 ` [PATCH 5/6] xen: arm: implement remap interfaces needed for privcmd mappings Ian Campbell
2012-10-18 13:27 ` Stefano Stabellini
2012-10-18 13:33 ` Ian Campbell
2012-10-18 13:35 ` Stefano Stabellini
2012-10-18 13:47 ` Ian Campbell
2012-10-17 11:32 ` [PATCH 6/6] xen: x86 pvh: use XENMEM_add_to_physmap_range for foreign gmfn mappings Ian Campbell
2012-10-17 23:57 ` Mukesh Rathor
2012-10-18 7:20 ` Ian Campbell
2012-10-18 13:30 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350473532-15863-3-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mukesh.rathor@oracle.com \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).