From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
lenb@kernel.org, linux-acpi@vger.kernel.org, hpa@zytor.com,
x86@kernel.org
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH 1/4] x86/wakeup/sleep: Check whether the TSS GDT descriptor is empty before using it.
Date: Wed, 17 Oct 2012 09:49:43 -0400 [thread overview]
Message-ID: <1350481786-4969-2-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1350481786-4969-1-git-send-email-konrad.wilk@oracle.com>
We check the TSS descriptor before we try to dereference it.
Also fix up the value to use the #defines.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
arch/x86/power/cpu.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/x86/power/cpu.c b/arch/x86/power/cpu.c
index 218cdb1..c17370e 100644
--- a/arch/x86/power/cpu.c
+++ b/arch/x86/power/cpu.c
@@ -133,7 +133,9 @@ static void fix_processor_context(void)
{
int cpu = smp_processor_id();
struct tss_struct *t = &per_cpu(init_tss, cpu);
-
+#ifdef CONFIG_X86_64
+ struct desc_struct *desc = get_cpu_gdt_table(cpu);
+#endif
set_tss_desc(cpu, t); /*
* This just modifies memory; should not be
* necessary. But... This is necessary, because
@@ -142,7 +144,8 @@ static void fix_processor_context(void)
*/
#ifdef CONFIG_X86_64
- get_cpu_gdt_table(cpu)[GDT_ENTRY_TSS].type = 9;
+ if (!desc_empty(&desc[GDT_ENTRY_TSS]))
+ desc[GDT_ENTRY_TSS].type = DESC_TSS;
syscall_init(); /* This sets MSR_*STAR and related */
#endif
--
1.7.7.6
next prev parent reply other threads:[~2012-10-17 14:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 13:49 [RFC] ACPI S3 and Xen (suprisingly small\!) Konrad Rzeszutek Wilk
2012-10-17 13:49 ` Konrad Rzeszutek Wilk [this message]
2012-10-18 0:03 ` [PATCH 1/4] x86/wakeup/sleep: Check whether the TSS GDT descriptor is empty before using it H. Peter Anvin
2012-10-18 14:47 ` Konrad Rzeszutek Wilk
2012-10-18 15:01 ` H. Peter Anvin
2013-01-17 14:41 ` Konrad Rzeszutek Wilk
2012-10-17 13:49 ` [PATCH 2/4] xen/lowlevel: Implement pvop call for load_idt (sidt) Konrad Rzeszutek Wilk
2012-10-17 23:51 ` H. Peter Anvin
2012-10-18 14:45 ` Konrad Rzeszutek Wilk
2012-10-18 15:02 ` H. Peter Anvin
2013-01-17 14:36 ` Konrad Rzeszutek Wilk
2012-10-17 13:49 ` [PATCH 3/4] xen/lowlevel: Implement pvop call for store_gdt (gidt) Konrad Rzeszutek Wilk
2012-10-17 13:49 ` [PATCH 4/4] xen/acpi: Prep saved_context cr3 values Konrad Rzeszutek Wilk
2013-01-17 14:48 ` Konrad Rzeszutek Wilk
2012-10-17 16:03 ` [RFC] ACPI S3 and Xen (suprisingly small\!) H. Peter Anvin
2012-10-17 16:10 ` Is: axe read_tscp pvops call. Was: " Konrad Rzeszutek Wilk
2012-10-17 16:39 ` Konrad Rzeszutek Wilk
2012-10-17 16:54 ` H. Peter Anvin
2012-10-17 16:50 ` H. Peter Anvin
2012-10-17 16:54 ` Konrad Rzeszutek Wilk
2012-10-17 17:35 ` H. Peter Anvin
2012-10-18 15:22 ` [Xen-devel] " Dan Magenheimer
2012-10-18 15:28 ` H. Peter Anvin
2012-10-18 15:56 ` Dan Magenheimer
2012-10-18 16:17 ` Borislav Petkov
2012-10-18 16:44 ` Stefano Stabellini
2012-10-18 17:04 ` H. Peter Anvin
2012-10-18 16:37 ` H. Peter Anvin
2012-10-19 15:48 ` Is: Xen architecture document. Was: " Konrad Rzeszutek Wilk
2012-10-19 17:45 ` H. Peter Anvin
2012-10-18 16:31 ` David Vrabel
2012-10-18 17:42 ` Konrad Rzeszutek Wilk
2012-10-18 18:02 ` David Vrabel
2012-10-17 17:46 ` Ben Guthro
2012-10-17 17:43 ` Konrad Rzeszutek Wilk
2012-10-17 18:00 ` Ben Guthro
2012-10-19 18:49 ` Konrad Rzeszutek Wilk
2012-10-20 1:23 ` Ben Guthro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350481786-4969-2-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).