Re: [PATCH] remove untouched code in kfifo_in

Jiri Kosina
2012-10-19T07:34:51Z

On Fri, 19 Oct 2012, Stefani Seibold wrote:

> > > In kfifo_in marco, one piece of code is arounded by if(0). This code in
> > > introduced by Stefani Seibold <stefani@seibold.net> to suppress a compiler
> > > warning. This warning is not there with the upgrade of gcc version.
> > >
> > > This patch just remove this code.
> >
> > Are you sure?
> > This code fragment looks like a compiler bomb to detect type mismatch to me...
>
> Yes, you are great! That was the reason why i made this peace of code.
> So don't remove it!

As even you, the author of the code, got confused by it for a while,
adding an explanatory comment seems appropriate.

Thanks,

--
Jiri Kosina
SUSE Labs