Re: [PATCH] remove untouched code in kfifo_in

Stefani Seibold
2012-10-18T05:34:55Z

Am Donnerstag, den 18.10.2012, 09:59 +0800 schrieb Richard Yang:
> On Wed, Oct 17, 2012 at 09:51:49PM +0200, Stefani Seibold wrote:
> >This was introduce by me to suppress a compiler warning, so don't remove
> >it.
> Which warning? I compile by removing this, but not find warning.
> I compile it on x86_64 platform.
> >

Sorry, i can't remember, it is three years and two gcc major releases
ago.

> >Am Mittwoch, den 17.10.2012, 16:05 +0200 schrieb Jiri Kosina:
> >> On Wed, 17 Oct 2012, Richard Yang wrote:
> >>
> >> > >> This patch just remove this code.
> >> > >> ---
> >> > >> include/linux/kfifo.h | 4 ----
> >> > >> 1 files changed, 0 insertions(+), 4 deletions(-)
> >> > >>
> >> > >> diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h
> >> > >> index 10308c6..e7015bb 100644
> >> > >> --- a/include/linux/kfifo.h
> >> > >> +++ b/include/linux/kfifo.h
> >> > >> @@ -512,10 +512,6 @@ __kfifo_uint_must_check_helper( \
> >> > >> unsigned long __n = (n); \
> >> > >> const size_t __recsize = sizeof(*__tmp->rectype); \
> >> > >> struct __kfifo *__kfifo = &__tmp->kfifo; \
> >> > >> - if (0) { \
> >> > >> - typeof(__tmp->ptr_const) __dummy __attribute__ ((unused)); \
> >> > >> - __dummy = (typeof(__buf))NULL; \
> >> > >> - } \
> >> > >> (__recsize) ?\
> >> > >> __kfifo_in_r(__kfifo, __buf, __n, __recsize) : \
> >> > >> __kfifo_in(__kfifo, __buf, __n); \
> >> > >
> >> > >Frankly, I'd first like to understand what was the rationale for adding it
> >> > >at the first place. Adding Stefani and lkml to CC.
> >> >
> >> > Agree.
> >> >
> >> > BTW, by git blame, I just see commit 2e956fb3 which is checked in by Stefani.
> >> > While looking in the diff, the kfifo_in() is already there. Looks like this
> >> > commit move the definition from one file to another file.
> >> >
> >> > So I am not sure the if(0) code is added by Stefani. Any other method to trace
> >> > the ealier history?
> >>
> >> git blame -- include/linux/kfifo-new.h 2e956fb3~1
> >>
> >
>