Re: [PATCH] remove untouched code in kfifo_in

Jiri Kosina
2012-10-17T12:37:25Z

On Wed, 17 Oct 2012, Wei Yang wrote:

> In kfifo_in marco, one piece of code is arounded by if(0).
>
> This patch just remove this code.
> ---
> include/linux/kfifo.h | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h
> index 10308c6..e7015bb 100644
> --- a/include/linux/kfifo.h
> +++ b/include/linux/kfifo.h
> @@ -512,10 +512,6 @@ __kfifo_uint_must_check_helper( \
> unsigned long __n = (n); \
> const size_t __recsize = sizeof(*__tmp->rectype); \
> struct __kfifo *__kfifo = &__tmp->kfifo; \
> - if (0) { \
> - typeof(__tmp->ptr_const) __dummy __attribute__ ((unused)); \
> - __dummy = (typeof(__buf))NULL; \
> - } \
> (__recsize) ?\
> __kfifo_in_r(__kfifo, __buf, __n, __recsize) : \
> __kfifo_in(__kfifo, __buf, __n); \

Frankly, I'd first like to understand what was the rationale for adding it
at the first place. Adding Stefani and lkml to CC.

--
Jiri Kosina
SUSE Labs