From: Stefani Seibold <stefani@seibold.net>
To: Richard Yang <weiyang@linux.vnet.ibm.com>
Cc: Jiri Kosina <jkosina@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove untouched code in kfifo_in
Date: Thu, 18 Oct 2012 07:34:06 +0200 [thread overview]
Message-ID: <1350538446.10942.1.camel@wall-e> (raw)
In-Reply-To: <20121018015959.GD4511@richard.(null)>
Am Donnerstag, den 18.10.2012, 09:59 +0800 schrieb Richard Yang:
> On Wed, Oct 17, 2012 at 09:51:49PM +0200, Stefani Seibold wrote:
> >This was introduce by me to suppress a compiler warning, so don't remove
> >it.
> Which warning? I compile by removing this, but not find warning.
> I compile it on x86_64 platform.
> >
Sorry, i can't remember, it is three years and two gcc major releases
ago.
> >Am Mittwoch, den 17.10.2012, 16:05 +0200 schrieb Jiri Kosina:
> >> On Wed, 17 Oct 2012, Richard Yang wrote:
> >>
> >> > >> This patch just remove this code.
> >> > >> ---
> >> > >> include/linux/kfifo.h | 4 ----
> >> > >> 1 files changed, 0 insertions(+), 4 deletions(-)
> >> > >>
> >> > >> diff --git a/include/linux/kfifo.h b/include/linux/kfifo.h
> >> > >> index 10308c6..e7015bb 100644
> >> > >> --- a/include/linux/kfifo.h
> >> > >> +++ b/include/linux/kfifo.h
> >> > >> @@ -512,10 +512,6 @@ __kfifo_uint_must_check_helper( \
> >> > >> unsigned long __n = (n); \
> >> > >> const size_t __recsize = sizeof(*__tmp->rectype); \
> >> > >> struct __kfifo *__kfifo = &__tmp->kfifo; \
> >> > >> - if (0) { \
> >> > >> - typeof(__tmp->ptr_const) __dummy __attribute__ ((unused)); \
> >> > >> - __dummy = (typeof(__buf))NULL; \
> >> > >> - } \
> >> > >> (__recsize) ?\
> >> > >> __kfifo_in_r(__kfifo, __buf, __n, __recsize) : \
> >> > >> __kfifo_in(__kfifo, __buf, __n); \
> >> > >
> >> > >Frankly, I'd first like to understand what was the rationale for adding it
> >> > >at the first place. Adding Stefani and lkml to CC.
> >> >
> >> > Agree.
> >> >
> >> > BTW, by git blame, I just see commit 2e956fb3 which is checked in by Stefani.
> >> > While looking in the diff, the kfifo_in() is already there. Looks like this
> >> > commit move the definition from one file to another file.
> >> >
> >> > So I am not sure the if(0) code is added by Stefani. Any other method to trace
> >> > the ealier history?
> >>
> >> git blame -- include/linux/kfifo-new.h 2e956fb3~1
> >>
> >
>
next prev parent reply other threads:[~2012-10-18 5:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1350463837-30244-1-git-send-email-weiyang@linux.vnet.ibm.com>
2012-10-17 12:37 ` [PATCH] remove untouched code in kfifo_in Jiri Kosina
[not found] ` <20121017140136.GA7913@richard.(null)>
2012-10-17 14:05 ` Jiri Kosina
2012-10-17 19:51 ` Stefani Seibold
[not found] ` <20121018015959.GD4511@richard.(null)>
2012-10-18 5:34 ` Stefani Seibold [this message]
2012-10-18 7:00 ` Jiri Kosina
2012-10-18 13:59 Wei Yang
2012-10-18 22:37 ` richard -rw- weinberger
2012-10-19 5:23 ` Stefani Seibold
2012-10-19 7:34 ` Jiri Kosina
2012-10-22 23:56 ` Andrew Morton
[not found] ` <508600ba.a7fe440a.4c19.fffff64bSMTPIN_ADDED@mx.google.com>
2012-10-23 19:25 ` richard -rw- weinberger
2012-10-23 19:39 ` Andrew Morton
[not found] ` <5080f0b3.85712b0a.0d0f.ffff9dd2SMTPIN_ADDED@mx.google.com>
2012-10-19 8:14 ` richard -rw- weinberger
[not found] ` <50810e61.688c320a.1baa.6cacSMTPIN_ADDED@mx.google.com>
2012-10-19 8:28 ` richard -rw- weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350538446.10942.1.camel@wall-e \
--to=stefani@seibold.net \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyang@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox