From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753060Ab2JVKfw (ORCPT ); Mon, 22 Oct 2012 06:35:52 -0400 Received: from casper.infradead.org ([85.118.1.10]:50780 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752907Ab2JVKfv convert rfc822-to-8bit (ORCPT ); Mon, 22 Oct 2012 06:35:51 -0400 Message-ID: <1350902138.2768.86.camel@twins> Subject: Re: [PATCH 1/6] perf, x86: Basic Haswell LBR call stack support From: Peter Zijlstra To: "Yan, Zheng" Cc: linux-kernel@vger.kernel.org, eranian@google.com, ak@linux.intel.com Date: Mon, 22 Oct 2012 12:35:38 +0200 In-Reply-To: <1350886279-6141-2-git-send-email-zheng.z.yan@intel.com> References: <1350886279-6141-1-git-send-email-zheng.z.yan@intel.com> <1350886279-6141-2-git-send-email-zheng.z.yan@intel.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2012-10-22 at 14:11 +0800, Yan, Zheng wrote: > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -160,8 +160,9 @@ enum perf_branch_sample_type { > PERF_SAMPLE_BRANCH_ABORT = 1U << 7, /* transaction aborts */ > PERF_SAMPLE_BRANCH_INTX = 1U << 8, /* in transaction (flag) */ > PERF_SAMPLE_BRANCH_NOTX = 1U << 9, /* not in transaction (flag) */ > + PERF_SAMPLE_BRANCH_CALL_STACK = 1U << 10, /* call stack */ > > - PERF_SAMPLE_BRANCH_MAX = 1U << 10, /* non-ABI */ > + PERF_SAMPLE_BRANCH_MAX = 1U << 11, /* non-ABI */ > }; You add an ABI sample type without mentioning it in your changelog.. I think I'll stop reading here.