Re: [PATCH 06/34] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation v2

Andi Kleen
2012-10-23T13:36:48Z

On Tue, Oct 23, 2012 at 03:35:27PM +0200, Andi Kleen wrote:
> > So I forgot how all this worked, but will the KVM emulation not pass
> > this straight down to the hardware?
>
> Pass down to perf.
>
> >
> > Don't we have a problem where we're emulating arch perfmon v1 on AMD
> > hardware? On AMD hardware those bits do have meaning.
>
> Ah they do? I wasn't aware. I can add a cpuid check for Intel I suppose.

Ah now I remember: I wrote it for the original qualifiers which would
have worked fine for AMD too. It just broke with the raw events you
asked for.

Ok will do the cpuid check to work around this problem.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.