Re: [PATCH 04/34] perf, x86: Support the TSX intx/intx_cp qualifiers

Andi Kleen
2012-10-23T13:33:02Z

On Tue, Oct 23, 2012 at 02:09:19PM +0200, Peter Zijlstra wrote:
> On Thu, 2012-10-18 at 16:19 -0700, Andi Kleen wrote:
> > @@ -826,7 +827,8 @@ static inline bool intel_pmu_needs_lbr_smpl(struct perf_event *event)
> > return true;
> >
> > /* implicit branch sampling to correct PEBS skid */
> > - if (x86_pmu.intel_cap.pebs_trap && event->attr.precise_ip > 1)
> > + if (x86_pmu.intel_cap.pebs_trap && event->attr.precise_ip > 1 &&
> > + x86_pmu.intel_cap.pebs_format < 2)
> > return true;
> >
> > return false;
>
> This seems unrelated to TSX, I suppose it belongs in the previous patch?

Ok will move.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.