Re: [PATCH 061/193] drivers/md: remove CONFIG_EXPERIMENTAL

Kees Cook
2012-10-23T20:26:16Z

On Tue, Oct 23, 2012 at 1:23 PM, NeilBrown <neilb@suse.de> wrote:
> On Tue, 23 Oct 2012 13:02:14 -0700 Kees Cook <keescook@chromium.org> wrote:
>
>> This config item has not carried much meaning for a while now and is
>> almost always enabled by default. As agreed during the Linux kernel
>> summit, remove it.
>>
>> CC: Neil Brown <neilb@suse.de>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> ---
>> drivers/md/Kconfig | 25 ++++++++++++-------------
>> 1 file changed, 12 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
>> index 91a02ee..f583e96 100644
>> --- a/drivers/md/Kconfig
>> +++ b/drivers/md/Kconfig
>> @@ -155,10 +155,9 @@ config MD_RAID456
>> If unsure, say Y.
>>
>> config MULTICORE_RAID456
>> - bool "RAID-4/RAID-5/RAID-6 Multicore processing (EXPERIMENTAL)"
>> + bool "RAID-4/RAID-5/RAID-6 Multicore processing"
>> depends on MD_RAID456
>> depends on SMP
>> - depends on EXPERIMENTAL
>> ---help---
>> Enable the raid456 module to dispatch per-stripe raid operations to a
>> thread pool.
>
> I'm happy to remove the "depends on EXPERIMENTAL".
> I'm not so happy to remove the "(EXPERIMENTAL)" text. That code really
> shouldn't be used in production - just for experiments.

No problem; I've updated the patch to leave the title alone.

Thanks!

-Kees

--
Kees Cook
Chrome OS Security