Re: [PATCH RFT RESEND linux-next] sparc: dma-mapping: support debug_dma_mapping_error

Shuah Khan
2012-11-15T17:39:38Z

On Fri, 2012-11-09 at 19:54 -0500, David Miller wrote:
> From: Shuah Khan <shuah.khan@hp.com>
> Date: Fri, 09 Nov 2012 17:52:23 -0700
>
> > On Fri, 2012-11-09 at 19:38 -0500, David Miller wrote:
> >> From: Shuah Khan <shuah.khan@hp.com>
> >> Date: Fri, 26 Oct 2012 10:13:09 -0600
> >>
> >> > Add support for debug_dma_mapping_error() call to avoid warning from
> >> > debug_dma_unmap() interface when it checks for mapping error checked
> >> > status. Without this patch, device driver failed to check map error
> >> > warning is generated.
> >> >
> >> > Signed-off-by: Shuah Khan <shuah.khan@hp.com>
> >>
> >> This doesn't even compile:
> >>
> >> /home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h: In function 'dma_mapping_error':
> >> /home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h:62:2: error: implicit declaration of function 'debug_dma
> >> _mapping_error' [-Werror=implicit-function-declaration]
> >> cc1: some warnings being treated as errors
> >> In file included from include/linux/dma-mapping.h:76:0,
> >> from include/linux/skbuff.h:33,
> >> from include/linux/icmpv6.h:4,
> >> from include/linux/ipv6.h:58,
> >> from include/net/ipv6.h:16,
> >> from include/linux/sunrpc/clnt.h:26,
> >> from include/linux/nfs_fs.h:30,
> >> from init/do_mounts.c:30:
> >
> > The problem the dependent patch is in linux-next and not in arch trees
> > yet. That is why I am trying it get this through linux-next and/or
> > dma-debug tree. I am open to suggestions on what is the best route.
>
> Then please put this in via the dma-debug tree:
>
> Acked-by: David S. Miller <davem@davemloft.net>

Marek,

This is for sparc to go through your tree.

Thanks,
-- Shuah