From: Shuah Khan <shuah.khan@hp.com>
To: dhowells@redhat.com
Cc: LKML <linux-kernel@vger.kernel.org>, shuahkhan@gmail.com
Subject: Re: [PATCH RFT linux-next] frv: dma-mapping: support debug_dma_mapping_error
Date: Fri, 26 Oct 2012 11:15:17 -0600 [thread overview]
Message-ID: <1351271717.4013.39.camel@lorien2> (raw)
In-Reply-To: <1351270093.4013.29.camel@lorien2>
On Fri, 2012-10-26 at 10:48 -0600, Shuah Khan wrote:
> Add support for debug_dma_mapping_error() call to avoid warning from
> debug_dma_unmap() interface when it checks for mapping error checked
> status. Without this patch, device driver failed to check map error
> warning is generated.
>
> Signed-off-by: Shuah Khan <shuah.khan@hp.com>
Please ignore this patch if frv doesn't use dma_map_page() and
dma_map_single() from arch/mips/include/asm/dma-mapping.
frv defines dma_map_page() and dma_map_single() in
arch/frv/mb93090-mb00/pci-dma.c and
arch/frv/mb93090-mb00/pci-dma-nommu.c
-- Shuah
> ---
> arch/frv/include/asm/dma-mapping.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/frv/include/asm/dma-mapping.h b/arch/frv/include/asm/dma-mapping.h
> index dfb8110..d8a8aac 100644
> --- a/arch/frv/include/asm/dma-mapping.h
> +++ b/arch/frv/include/asm/dma-mapping.h
> @@ -6,6 +6,7 @@
> #include <asm/cacheflush.h>
> #include <asm/scatterlist.h>
> #include <asm/io.h>
> +#include <linux/dma-debug.h>
>
> /*
> * See Documentation/DMA-API.txt for the description of how the
> @@ -97,6 +98,7 @@ void dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg, int nele
> static inline
> int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
> {
> + debug_dma_mapping_error(dev, dma_addr);
> return 0;
> }
>
next prev parent reply other threads:[~2012-10-26 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 16:48 [PATCH RFT linux-next] frv: dma-mapping: support debug_dma_mapping_error Shuah Khan
2012-10-26 17:15 ` Shuah Khan [this message]
2012-11-15 18:17 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351271717.4013.39.camel@lorien2 \
--to=shuah.khan@hp.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox