linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Arun Sharma <asharma@fb.com>, David Ahern <dsahern@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>
Subject: Re: [RFC/PATCHSET 00/15] perf report: Add support to accumulate hist periods
Date: Mon, 29 Oct 2012 20:08:47 +0100	[thread overview]
Message-ID: <1351537727.4047.21.camel@twins> (raw)
In-Reply-To: <1347520811-28150-1-git-send-email-namhyung@kernel.org>

On Thu, 2012-09-13 at 16:19 +0900, Namhyung Kim wrote:
> When --cumulate option is given, it'll be shown like this:
> 
>    $ perf report --cumulate
>    (...)
>    +  93.63%  abc  libc-2.15.so        [.] __libc_start_main
>    +  93.35%  abc  abc                 [.] main
>    +  93.35%  abc  abc                 [.] c
>    +  93.35%  abc  abc                 [.] b
>    +  93.35%  abc  abc                 [.] a
>    +   5.17%  abc  ld-2.15.so          [.] _dl_map_object
>    +   5.17%  abc  ld-2.15.so          [.] _dl_map_object_from_fd
>    +   1.13%  abc  ld-2.15.so          [.] _dl_start_user
>    +   1.13%  abc  ld-2.15.so          [.] _dl_start
>    +   0.29%  abc  perf                [.] main
>    +   0.29%  abc  perf                [.] run_builtin
>    +   0.29%  abc  perf                [.] cmd_record
>    +   0.29%  abc  libpthread-2.15.so  [.] __libc_close
>    +   0.07%  abc  ld-2.15.so          [.] _start
>    +   0.07%  abc  [kernel.kallsyms]   [k] page_fault
>    
> (This output came from TUI since stdio bothered by callchains) 

Right, so I tried this and I would expect the callchains to be inverted
too, so that when I expand say 'c' I would see that 'c' calls 'b' for
100% which calls 'a' for 100%.

Instead I get the regular callchains, expanding 'c' gives me main calls
it for 100%.

Adding -G (invert callchains) doesn't make it better, in that case, when
I expand 'c' we start at '__libc_start_main' instead of 'c'.

Is there anything I'm missing?

  parent reply	other threads:[~2012-10-29 19:09 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13  7:19 [RFC/PATCHSET 00/15] perf report: Add support to accumulate hist periods Namhyung Kim
2012-09-13  7:19 ` [PATCH 01/15] perf hists: Add missing period_* fields when collapsing a hist entry Namhyung Kim
2012-09-13  7:19 ` [PATCH 02/15] perf hists: Introduce struct he_stat Namhyung Kim
2012-09-13  7:19 ` [PATCH 03/15] perf hists: Move he->stat.nr_events initialization to a template Namhyung Kim
2012-09-13  7:20 ` [PATCH 04/15] perf hists: Convert hist entry functions to use struct he_stat Namhyung Kim
2012-09-13  7:20 ` [PATCH 05/15] perf hists: Add more helpers for hist entry stat Namhyung Kim
2012-09-13  7:20 ` [PATCH 06/15] perf hists: Add support for accumulated stat of hist entry Namhyung Kim
2012-09-13  7:20 ` [PATCH 07/15] perf hists: Check if accumulated when adding a " Namhyung Kim
2012-09-13  7:20 ` [PATCH 08/15] perf callchain: Add a couple of callchain helpers Namhyung Kim
2012-09-13  7:20 ` [PATCH 09/15] perf hists: Let add_hist_entry to make a hist entry template Namhyung Kim
2012-09-13  7:20 ` [PATCH 10/15] perf hists: Accumulate hist entry stat based on the callchain Namhyung Kim
2012-09-13  7:20 ` [PATCH 11/15] perf hists: Sort hist entries by accumulated period Namhyung Kim
2012-09-13  7:20 ` [PATCH 12/15] perf ui/hist: Add support to accumulated hist stat Namhyung Kim
2012-09-13  7:20 ` [PATCH 13/15] perf ui/browser: " Namhyung Kim
2012-09-13  7:20 ` [PATCH 14/15] perf ui/gtk: " Namhyung Kim
2012-09-13  7:20 ` [PATCH 15/15] perf report: Add --cumulate option Namhyung Kim
2012-09-20 17:33 ` [RFC/PATCHSET 00/15] perf report: Add support to accumulate hist periods Arun Sharma
2012-09-25  4:57 ` Namhyung Kim
2012-09-27 23:01   ` Frederic Weisbecker
2012-09-28  5:49     ` Namhyung Kim
2012-09-28  7:07       ` Stephane Eranian
2012-09-28 15:14         ` Frederic Weisbecker
2012-09-28 16:36           ` Stephane Eranian
2012-09-28 15:27       ` Frederic Weisbecker
2012-10-29 19:08 ` Peter Zijlstra [this message]
2012-10-29 21:36   ` Arun Sharma
2012-10-30  6:59     ` Namhyung Kim
2012-10-30  8:17       ` Peter Zijlstra
2012-10-30  9:01         ` Ingo Molnar
2012-10-31  7:24           ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351537727.4047.21.camel@twins \
    --to=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=asharma@fb.com \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).