Re: [Patch v1 06/10] perf/x86: add support for PEBS Precise Store

Stephane Eranian
2012-10-29T15:44:18Z

On Mon, Oct 29, 2012 at 4:40 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Mon, 2012-10-29 at 16:15 +0100, Stephane Eranian wrote:
>> - if (fll) {
>> + if (fll || fst) {
>> if (sample_type & PERF_SAMPLE_ADDR)
>> data.addr = pebs->dla;
>>
>> @@ -688,6 +731,8 @@ static void __intel_pmu_pebs_event(struct perf_event *event,
>> if (sample_type & PERF_SAMPLE_DSRC) {
>> if (fll)
>> data.dsrc.val = load_latency_data(pebs->dse);
>> + else if (fst)
>> + data.dsrc.val = precise_store_data(pebs->dse);
>> }
>> }
>>
>
> Ah, this is why I guess.. hrm.. ok, n/m then.

Yes, it is. But your proposal and my extension for Precise Store look good too.