* regulator: tps51632: Seems current code doesn't properly support dvfs_step_20mV case
@ 2012-11-01 6:48 Axel Lin
2012-11-01 7:46 ` Laxman Dewangan
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-11-01 6:48 UTC (permalink / raw)
To: Laxman Dewangan; +Cc: Mark Brown, Liam Girdwood, linux-kernel
Hi Laxman,
While reading the tps51632 driver, I found there is a dvfs_step_20mV setting
in platform data. But seems current code doesn't properly handle the case when
dvfs_step_20mV is true.
I guess if pdata->dvfs_step_20mV is true, we need:
tps->desc.uV_step = TPS51632_VOLATGE_STEP_20mV;
Fix TPS51632_VOLT_VSEL macro to support dvfs_step_20mV case.
Also I'm wondering if either TPS51632_MAX_VSEL/TPS51632_MAX_VOLATGE or
desc.n_voltages needs change for dvfs_step_20mV case.
Oh, I don't have the datasheet, so my understanding might be wrong.
Regards,
Axel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: regulator: tps51632: Seems current code doesn't properly support dvfs_step_20mV case
2012-11-01 6:48 regulator: tps51632: Seems current code doesn't properly support dvfs_step_20mV case Axel Lin
@ 2012-11-01 7:46 ` Laxman Dewangan
0 siblings, 0 replies; 2+ messages in thread
From: Laxman Dewangan @ 2012-11-01 7:46 UTC (permalink / raw)
To: Axel Lin; +Cc: Mark Brown, Liam Girdwood, linux-kernel@vger.kernel.org
On Thursday 01 November 2012 12:18 PM, Axel Lin wrote:
> Hi Laxman,
>
> While reading the tps51632 driver, I found there is a dvfs_step_20mV setting
> in platform data. But seems current code doesn't properly handle the case when
> dvfs_step_20mV is true.
>
> I guess if pdata->dvfs_step_20mV is true, we need:
>
> tps->desc.uV_step = TPS51632_VOLATGE_STEP_20mV;
> Fix TPS51632_VOLT_VSEL macro to support dvfs_step_20mV case.
> Also I'm wondering if either TPS51632_MAX_VSEL/TPS51632_MAX_VOLATGE or
> desc.n_voltages needs change for dvfs_step_20mV case.
>
> Oh, I don't have the datasheet, so my understanding might be wrong.
The steps for voltage and voltage base registers are the 10mV always.
The DVFS steps are used only when the steps (offsets) are provided
through PWM.
So in DVFS case the vout = voltage_base + pwm_offset* dvfs_steps.
And voltage_base = min_volt + sel * 10mV.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-01 7:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-01 6:48 regulator: tps51632: Seems current code doesn't properly support dvfs_step_20mV case Axel Lin
2012-11-01 7:46 ` Laxman Dewangan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox