From: Luming Yu <luming.yu@gmail.com>
To: arnd@arndb.de, linux-kernel@vger.kernel.org
Cc: Luming Yu <luming.yu@gmail.com>, Luming Yu <luming.yu@intel.com>
Subject: [PATCH 09/13] HW-latency: Fix unwanted crash caused by write to dummy debugfs interface
Date: Sun, 4 Nov 2012 20:59:40 -0500 [thread overview]
Message-ID: <1352080784-30839-10-git-send-email-luming.yu@gmail.com> (raw)
In-Reply-To: <1352080784-30839-1-git-send-email-luming.yu@gmail.com>
[ 141.311906] BUG: unable to handle kernel NULL pointer dereference at 0000000000000008
[ 141.314071] IP: [<ffffffff811f8f3c>] simple_attr_write+0x2c/0x100
[ 141.316195] PGD c3bd7067 PUD cb41d067 PMD 0
[ 141.318287] Oops: 0000 [#1] SMP
[ 141.320338] Modules linked in: hw_latency_test lockd sunrpc iptable_mangle nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack nf_conntrack rfcomm bnep coretemp kvm arc4 iwldvm mac80211 snd_hda_codec_hdmi snd_hda_codec_realtek option usb_wwan snd_hda_intel snd_hda_codec btusb bluetooth snd_hwdep snd_seq snd_seq_device snd_pcm iwlwifi thinkpad_acpi cfg80211 snd_page_alloc snd_timer crc32c_intel snd e1000e tpm_tis ghash_clmulni_intel tpm tpm_bios soundcore iTCO_wdt rfkill joydev microcode i2c_i801 wmi iTCO_vendor_support mei lpc_ich mfd_core pcspkr uinput i915 usb_storage i2c_algo_bit uas drm_kms_helper sdhci_pci sdhci drm mmc_core i2c_core video
[ 141.329446] CPU 2
[ 141.329467] Pid: 804, comm: bash Not tainted 3.7.0-rc2+ #5 LENOVO 232045C/232045C
[ 141.333922] RIP: 0010:[<ffffffff811f8f3c>] [<ffffffff811f8f3c>] simple_attr_write+0x2c/0x100
[ 141.336173] RSP: 0018:ffff8800cb6c3eb8 EFLAGS: 00010286
[ 141.338377] RAX: ffffffff811f8f10 RBX: ffff8800c4549600 RCX: ffff8800cb6c3f50
[ 141.340573] RDX: 0000000000000002 RSI: 00007fcbf9ef0000 RDI: ffff8800c4549600
[ 141.342744] RBP: ffff8800cb6c3ef8 R08: 000000000000000a R09: 00007fcbf9edd740
[ 141.344896] R10: 0000000000000001 R11: 0000000000000246 R12: 0000000000000002
[ 141.347017] R13: 00007fcbf9ef0000 R14: ffff8800cb6c3f50 R15: 0000000000000000
[ 141.349115] FS: 00007fcbf9edd740(0000) GS:ffff880119200000(0000) knlGS:0000000000000000
[ 141.351209] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 141.353314] CR2: 0000000000000008 CR3: 00000000c696c000 CR4: 00000000001407e0
[ 141.355457] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 141.357590] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[ 141.359685] Process bash (pid: 804, threadinfo ffff8800cb6c2000, task ffff8800cb7ccd20)
[ 141.361767] Stack:
[ 141.363793] ffff8800c4549600 00007fcbf9ef0000 ffff8800cb6c3ef8 ffff8800c4549600
[ 141.365864] 0000000000000002 00007fcbf9ef0000 ffff8800cb6c3f50 0000000000000000
[ 141.367905] ffff8800cb6c3f28 ffffffff811cf27f ffff8800c4549600 00007fcbf9ef0000
[ 141.369924] Call Trace:
[ 141.371882] [<ffffffff811cf27f>] vfs_write+0xaf/0x190
[ 141.373827] [<ffffffff811cf5d5>] sys_write+0x55/0xa0
[ 141.375745] [<ffffffff816f0199>] system_call_fastpath+0x16/0x1b
[ 141.377661] Code: 1f 44 00 00 55 48 89 e5 48 83 ec 40 48 89 5d d8 4c 89 65 e0 4c 89 6d e8 4c 89 75 f0 4c 89 7d f8 4c 8b bf 28 01 00 00 48 89 75 c8 <49> 83 7f 08 00 0f 84 b1 00 00 00 4d 8d 67 50 31 f6 49 89 d5 4c
[ 141.382206] RIP [<ffffffff811f8f3c>] simple_attr_write+0x2c/0x100
[ 141.384326] RSP <ffff8800cb6c3eb8>
[ 141.386401] CR2: 0000000000000008
[ 141.388548] ---[ end trace 9c28eee46fcb7871 ]---
Signed-off-by: Luming Yu <luming.yu@intel.com>
---
fs/libfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/libfs.c b/fs/libfs.c
index 7cc37ca..bc51574 100644
--- a/fs/libfs.c
+++ b/fs/libfs.c
@@ -819,7 +819,7 @@ ssize_t simple_attr_write(struct file *file, const char __user *buf,
ssize_t ret;
attr = file->private_data;
- if (!attr->set)
+ if (!attr || !attr->set)
return -EACCES;
ret = mutex_lock_interruptible(&attr->mutex);
--
1.7.12.1
next prev parent reply other threads:[~2012-11-04 13:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 1:59 [PATCH 00/13] A simple hardware detector for latency as well as throughtput ver 0.10 Luming Yu
2012-11-05 1:59 ` [PATCH 01/13] HW-latency: hardware latency test 0.10 Luming Yu
2012-11-04 21:07 ` Maarten Lankhorst
2012-11-05 12:14 ` Luming Yu
2012-11-04 21:23 ` John Kacur
2012-11-05 12:20 ` Luming Yu
2012-11-05 8:44 ` No recipient
2012-11-05 8:44 ` Ove Karlsen
2012-11-05 1:59 ` [PATCH 02/13] HW-latency: Fix a lockdep warnning Luming Yu
2012-11-05 1:59 ` [PATCH 03/13] HW-latency: Use get_random_bytes_arch Luming Yu
2012-11-05 1:59 ` [PATCH 04/13] HW-latency: Differentiate three modes to use CPU carry out testing Luming Yu
2012-11-05 1:59 ` [PATCH 05/13] HW-latency: Add CPU field in sample output Luming Yu
2012-11-05 1:59 ` [PATCH 06/13] HW-latency: cycle through all online cpus to re-test cpufreq Luming Yu
2012-11-05 1:59 ` [PATCH 07/13] HW-latency: delete too many "Fast TSC calibration using PIT" in cpufreq sampling Luming Yu
2012-11-05 1:59 ` [PATCH 08/13] HW-latency: A stupid memory scanner for raw memory latency test Luming Yu
2012-11-05 1:59 ` Luming Yu [this message]
2012-11-05 1:59 ` [PATCH 10/13] HW-latency: add address range for x86-32 Luming Yu
2012-11-05 1:59 ` [PATCH 11/13] HW-latency: fix a warnning in previous patch Luming Yu
2012-11-05 1:59 ` [PATCH 12/13] HW-latency: Add sample unit in sample data Luming Yu
2012-11-05 1:59 ` [PATCH 13/13] HW-latency: some sample data format change Luming Yu
2012-11-08 16:04 ` [PATCH 00/13] A simple hardware detector for latency as well as throughtput ver 0.10 Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352080784-30839-10-git-send-email-luming.yu@gmail.com \
--to=luming.yu@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luming.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox