linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Devendra Naga <develkernel412222@gmail.com>
Subject: Re: [PATCH] thermal: rcar: fixup compilation errors
Date: Wed, 07 Nov 2012 11:34:39 +0800	[thread overview]
Message-ID: <1352259279.2137.15.camel@rzhang1-mobl4> (raw)
In-Reply-To: <87391ot63w.wl%kuninori.morimoto.gx@renesas.com>

On Tue, 2012-10-09 at 01:14 -0700, Kuninori Morimoto wrote:
> This patch fixup following error
> 
> ${LINUX}/drivers/thermal/rcar_thermal.c: In function 'rcar_thermal_probe':
> ${LINUX}/drivers/thermal/rcar_thermal.c:214:9: warning: passing argument 3 \
> 	of 'thermal_zone_device_register' makes integer from pointer without\
> 	a cast [enabled by default]
> ${LINUX}/include/linux/thermal.h:215:29: note: expected 'int' but argument \
> 	is of type 'struct rcar_thermal_priv *'
> ${LINUX}/drivers/thermal/rcar_thermal.c:214:9:\
> 	error: too few arguments to function 'thermal_zone_device_register'
> 
> Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

shipped in 3.7-rc4.

thanks,
rui
> ---
> for linus/master branch
> 
>  drivers/thermal/rcar_thermal.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> index b13fe5d..762f637 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -210,7 +210,7 @@ static int rcar_thermal_probe(struct platform_device *pdev)
>  		goto error_free_priv;
>  	}
>  
> -	zone = thermal_zone_device_register("rcar_thermal", 0, priv,
> +	zone = thermal_zone_device_register("rcar_thermal", 0, 0, priv,
>  				    &rcar_thermal_zone_ops, NULL, 0, 0);
>  	if (IS_ERR(zone)) {
>  		dev_err(&pdev->dev, "thermal zone device is NULL\n");



  reply	other threads:[~2012-11-07  3:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-21 16:31 [PATCH] thermal: solve compilation errors in rcar_thermal Devendra Naga
2012-08-28  1:05 ` Kuninori Morimoto
2012-10-03  6:51 ` [PATCH] thermal: rcar_thermal: remove explicitly used devm_kfree/iounap() Kuninori Morimoto
2012-11-07  3:32   ` Zhang Rui
2012-10-09  8:14 ` [PATCH] thermal: rcar: fixup compilation errors Kuninori Morimoto
2012-11-07  3:34   ` Zhang Rui [this message]
2012-10-31  3:21 ` [PATCH] thermal: solve compilation errors in rcar_thermal Kuninori Morimoto
2012-10-31  6:24   ` Zhang, Rui
2012-10-31  8:46     ` Kuninori Morimoto
2012-11-01  2:17       ` Zhang, Rui
2012-11-01  2:29   ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352259279.2137.15.camel@rzhang1-mobl4 \
    --to=rui.zhang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=develkernel412222@gmail.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).