public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Airlie <airlied@redhat.com>
To: linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Dave Airlie <airlied@redhat.com>,
	Huang Ying <ying.huang@intel.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: [PATCH] pci/runtime-pm: respect devices autosuspend timeout on config access
Date: Wed,  7 Nov 2012 15:30:09 +1000	[thread overview]
Message-ID: <1352266209-29796-1-git-send-email-airlied@redhat.com> (raw)

So I've been adding runtime pm to nouveau/radeon, and on X start it does a
lot of pci accesses. Now because the pm on these devices is equivalent
to D3cold, we have to resume them which involves a heavy latency due to
POSTing the cards. The driver configures the autosuspend timeout to 5s for
this reason, and I think the PCI layer config accesses should respect
the autosuspend.

Cc: Huang Ying <ying.huang@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/pci/pci-sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 02d107b..12d3d52 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -487,7 +487,7 @@ pci_config_pm_runtime_put(struct pci_dev *pdev)
 	struct device *dev = &pdev->dev;
 	struct device *parent = dev->parent;
 
-	pm_runtime_put(dev);
+	pm_runtime_put_autosuspend(dev);
 	if (parent)
 		pm_runtime_put_sync(parent);
 }
-- 
1.7.12.1


             reply	other threads:[~2012-11-07  5:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-07  5:30 Dave Airlie [this message]
2012-11-07  5:58 ` [PATCH] pci/runtime-pm: respect devices autosuspend timeout on config access Huang Ying
2012-11-07  6:15   ` David Airlie
2012-11-07  6:26     ` Huang Ying
2012-11-07  6:31       ` David Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352266209-29796-1-git-send-email-airlied@redhat.com \
    --to=airlied@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox