From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <ak@linux.intel.com>,
Namhyung Kim <namhyung.kim@lge.com>
Subject: [PATCH 6/6] perf tools: Free {branch,mem}_info when freeing hist_entry
Date: Wed, 7 Nov 2012 16:27:14 +0900 [thread overview]
Message-ID: <1352273234-28912-7-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1352273234-28912-1-git-send-email-namhyung@kernel.org>
From: Namhyung Kim <namhyung.kim@lge.com>
Those data should be free along with the associated hist_entry,
otherwise they'll be leaked.
Cc: Stephane Eranian <eranian@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/hist.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 52fe4e24502b..50030133fb3b 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -470,6 +470,8 @@ hist_entry__collapse(struct hist_entry *left, struct hist_entry *right)
void hist_entry__free(struct hist_entry *he)
{
+ free(he->branch_info);
+ free(he->mem_info);
free(he);
}
--
1.7.11.7
next prev parent reply other threads:[~2012-11-07 7:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 7:27 [RFC/PATCH 0/6] perf tools: Additional works for memory access sampling Namhyung Kim
2012-11-07 7:27 ` [PATCH 1/6] perf tools: Synthesize data mmap events for threads Namhyung Kim
2012-11-08 14:55 ` Arnaldo Carvalho de Melo
2012-11-07 7:27 ` [PATCH 2/6] perf tools: Set kernel data mapping length Namhyung Kim
2012-11-14 7:29 ` [tip:perf/core] perf machine: " tip-bot for Namhyung Kim
2012-11-07 7:27 ` [PATCH 3/6] perf tools: Fix detection of stack area Namhyung Kim
2012-11-14 7:30 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-11-07 7:27 ` [PATCH 4/6] perf tools: Ignore ABS symbols when loading data maps Namhyung Kim
2012-11-07 7:27 ` [PATCH 5/6] perf tools: Fix output of symbol_daddr offset Namhyung Kim
2012-11-07 7:27 ` Namhyung Kim [this message]
2012-11-14 7:31 ` [tip:perf/core] perf hists: Free branch_info when freeing hist_entry tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352273234-28912-7-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox