* [PATCH 1/2] gpio: tegra: Staticize non-exported symbols
@ 2012-11-08 2:45 Axel Lin
2012-11-08 2:47 ` [PATCH 2/2] gpio: tegra: Drop exporting static functions Axel Lin
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Axel Lin @ 2012-11-08 2:45 UTC (permalink / raw)
To: Grant Likely, Linus Walleij; +Cc: Stephen Warren, linux-kernel
Both tegra_gpio_request() and tegra_gpio_free() are not referenced outside of
this file, make them static.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-tegra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index c7c175a..d5c01f0 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -117,12 +117,12 @@ static void tegra_gpio_disable(int gpio)
}
EXPORT_SYMBOL_GPL(tegra_gpio_disable);
-int tegra_gpio_request(struct gpio_chip *chip, unsigned offset)
+static int tegra_gpio_request(struct gpio_chip *chip, unsigned offset)
{
return pinctrl_request_gpio(offset);
}
-void tegra_gpio_free(struct gpio_chip *chip, unsigned offset)
+static void tegra_gpio_free(struct gpio_chip *chip, unsigned offset)
{
pinctrl_free_gpio(offset);
tegra_gpio_disable(offset);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] gpio: tegra: Drop exporting static functions
2012-11-08 2:45 [PATCH 1/2] gpio: tegra: Staticize non-exported symbols Axel Lin
@ 2012-11-08 2:47 ` Axel Lin
2012-11-08 21:36 ` Linus Walleij
2012-11-08 5:28 ` [PATCH 1/2] gpio: tegra: Staticize non-exported symbols Stephen Warren
2012-11-08 21:34 ` Linus Walleij
2 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2012-11-08 2:47 UTC (permalink / raw)
To: Grant Likely, Linus Walleij; +Cc: Stephen Warren, linux-kernel
Both tegra_gpio_enable() and tegra_gpio_disable() are static functions, it does
not make sense to export them.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-tegra.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index d5c01f0..f6cf98f 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -109,13 +109,11 @@ static void tegra_gpio_enable(int gpio)
{
tegra_gpio_mask_write(GPIO_MSK_CNF(gpio), gpio, 1);
}
-EXPORT_SYMBOL_GPL(tegra_gpio_enable);
static void tegra_gpio_disable(int gpio)
{
tegra_gpio_mask_write(GPIO_MSK_CNF(gpio), gpio, 0);
}
-EXPORT_SYMBOL_GPL(tegra_gpio_disable);
static int tegra_gpio_request(struct gpio_chip *chip, unsigned offset)
{
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] gpio: tegra: Staticize non-exported symbols
2012-11-08 2:45 [PATCH 1/2] gpio: tegra: Staticize non-exported symbols Axel Lin
2012-11-08 2:47 ` [PATCH 2/2] gpio: tegra: Drop exporting static functions Axel Lin
@ 2012-11-08 5:28 ` Stephen Warren
2012-11-08 21:34 ` Linus Walleij
2 siblings, 0 replies; 5+ messages in thread
From: Stephen Warren @ 2012-11-08 5:28 UTC (permalink / raw)
To: Axel Lin; +Cc: Grant Likely, Linus Walleij, linux-kernel
On 11/07/2012 07:45 PM, Axel Lin wrote:
> Both tegra_gpio_request() and tegra_gpio_free() are not referenced outside of
> this file, make them static.
Both patches,
Acked-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] gpio: tegra: Staticize non-exported symbols
2012-11-08 2:45 [PATCH 1/2] gpio: tegra: Staticize non-exported symbols Axel Lin
2012-11-08 2:47 ` [PATCH 2/2] gpio: tegra: Drop exporting static functions Axel Lin
2012-11-08 5:28 ` [PATCH 1/2] gpio: tegra: Staticize non-exported symbols Stephen Warren
@ 2012-11-08 21:34 ` Linus Walleij
2 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2012-11-08 21:34 UTC (permalink / raw)
To: Axel Lin; +Cc: Grant Likely, Stephen Warren, linux-kernel
On Thu, Nov 8, 2012 at 3:45 AM, Axel Lin <axel.lin@ingics.com> wrote:
> Both tegra_gpio_request() and tegra_gpio_free() are not referenced outside of
> this file, make them static.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Applied with Stephen's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-11-08 21:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-08 2:45 [PATCH 1/2] gpio: tegra: Staticize non-exported symbols Axel Lin
2012-11-08 2:47 ` [PATCH 2/2] gpio: tegra: Drop exporting static functions Axel Lin
2012-11-08 21:36 ` Linus Walleij
2012-11-08 5:28 ` [PATCH 1/2] gpio: tegra: Staticize non-exported symbols Stephen Warren
2012-11-08 21:34 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).