From: Peter Hurley <peter@hurleysoftware.com>
To: linux-kernel@vger.kernel.org
Cc: Peter Hurley <peter@hurleysoftware.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH 3/5] resources: Print warning when inserting resource [mem 0x00000000]
Date: Wed, 7 Nov 2012 21:55:54 -0500 [thread overview]
Message-ID: <1352343356-4006-4-git-send-email-peter@hurleysoftware.com> (raw)
In-Reply-To: <1352343356-4006-1-git-send-email-peter@hurleysoftware.com>
Inserting iomem resource [0x0-0x0] is most likely a bug; at least
print a warning message. Eg.,
resource: inserting NULL resource iTCO_wdt [mem 0x00000000]
Cc: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
kernel/resource.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/resource.c b/kernel/resource.c
index 268b5fa..ab758bb 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -589,6 +589,9 @@ static struct resource * __insert_resource(struct resource *parent, struct resou
{
struct resource *first, *next;
+ if (new->flags & IORESOURCE_MEM && !new->start && !new->end)
+ pr_warn("inserting NULL resource %s %pR", new->name, new);
+
for (;; parent = first) {
first = __request_resource(parent, new);
if (!first)
--
1.7.12.3
next prev parent reply other threads:[~2012-11-08 2:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 2:55 [PATCH 0/5] Add diagnostics for iomem resources Peter Hurley
2012-11-08 2:55 ` [PATCH 1/5] resources: Print resource ranges when expanding overlaps Peter Hurley
2012-11-08 2:55 ` [PATCH 2/5] resources: Print resource conflicts for failed requests Peter Hurley
2012-11-08 2:55 ` Peter Hurley [this message]
2012-11-08 2:55 ` [PATCH 4/5] x86: acpi: Print warning for malformed host bridge resources Peter Hurley
2012-11-10 21:52 ` Bjorn Helgaas
2012-11-11 14:49 ` Peter Hurley
2012-12-14 12:51 ` Peter Hurley
2012-11-08 2:55 ` [PATCH 5/5] drivers: mfd: Fix resource request for [mem 0x00000000] Peter Hurley
2012-11-08 17:04 ` Aaron Sierra
2012-11-08 18:24 ` Peter Hurley
2012-11-08 18:58 ` Aaron Sierra
2012-11-09 11:55 ` [PATCH v3] mfd: lpc_ich: " Peter Hurley
2012-11-19 17:46 ` Samuel Ortiz
2012-11-19 18:28 ` Peter Hurley
2012-11-21 16:33 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352343356-4006-4-git-send-email-peter@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).