From: David Sharp <dhsharp@google.com>
To: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Cc: Vaibhav Nagarnaik <vnagarnaik@google.com>,
David Sharp <dhsharp@google.com>
Subject: [PATCH 3/4] kernel-shark: Don't check for system name for sched events
Date: Wed, 14 Nov 2012 17:51:13 -0800 [thread overview]
Message-ID: <1352944274-21699-3-git-send-email-dhsharp@google.com> (raw)
In-Reply-To: <1352944274-21699-1-git-send-email-dhsharp@google.com>
From: Vaibhav Nagarnaik <vnagarnaik@google.com>
The sched tracepoint names are unique and so there is no need to check
for the subsystem name while looking up the event ID.
This helps kernel shark display the graphs correctly for trace.dat files
generated from trace collection mechanisms that don't record the subsystem.
Google-Bug-Id: 6333917
Signed-off-by: Vaibhav Nagarnaik <vnagarnaik@google.com>
Signed-off-by: David Sharp <dhsharp@google.com>
---
trace-graph.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/trace-graph.c b/trace-graph.c
index 4d81219..6f72350 100644
--- a/trace-graph.c
+++ b/trace-graph.c
@@ -1016,7 +1016,7 @@ int trace_graph_check_sched_wakeup(struct graph_info *ginfo,
found = FALSE;
event = pevent_find_event_by_name(ginfo->pevent,
- "sched", "sched_wakeup");
+ NULL, "sched_wakeup");
if (event) {
found = TRUE;
ginfo->event_wakeup_id = event->id;
@@ -1026,7 +1026,7 @@ int trace_graph_check_sched_wakeup(struct graph_info *ginfo,
event = pevent_find_event_by_name(ginfo->pevent,
- "sched", "sched_wakeup_new");
+ NULL, "sched_wakeup_new");
if (event) {
found = TRUE;
ginfo->event_wakeup_new_id = event->id;
@@ -1086,7 +1086,7 @@ int trace_graph_check_sched_switch(struct graph_info *ginfo,
if (ginfo->event_sched_switch_id < 0) {
event = pevent_find_event_by_name(ginfo->pevent,
- "sched", "sched_switch");
+ NULL, "sched_switch");
if (!event)
return 0;
--
1.7.7.3
next prev parent reply other threads:[~2012-11-15 1:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 1:51 [PATCH 1/4] kernelshark: Fix bug with Plot CPU filtering David Sharp
2012-11-15 1:51 ` [PATCH 2/4] kernel-shark: Allow unsetting of all CPUs in filter David Sharp
2012-11-15 2:20 ` Steven Rostedt
2012-11-15 1:51 ` David Sharp [this message]
2012-11-15 1:51 ` [PATCH 4/4] kernelshark: Full-height cursor and mark lines David Sharp
2012-11-15 2:27 ` Steven Rostedt
2012-11-15 19:55 ` David Sharp
2012-11-15 1:52 ` [PATCH 1/4] kernelshark: Fix bug with Plot CPU filtering David Sharp
2012-11-15 2:31 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2012-11-15 1:48 David Sharp
2012-11-15 1:48 ` [PATCH 3/4] kernel-shark: Don't check for system name for sched events David Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352944274-21699-3-git-send-email-dhsharp@google.com \
--to=dhsharp@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=vnagarnaik@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).