From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: viresh kumar <viresh.kumar@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>,
spear-devel <spear-devel@list.st.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dw_dmac: check direction properly in dw_dma_cyclic_prep
Date: Thu, 15 Nov 2012 17:17:27 +0200 [thread overview]
Message-ID: <1352992647.11158.334.camel@smile> (raw)
In-Reply-To: <CAOh2x=kxxKgMQQW8zvg+Y9F94YoPc5yK9gPY3_+FE2QMhpq6Ug@mail.gmail.com>
On Thu, 2012-11-15 at 20:28 +0530, viresh kumar wrote:
> On Thu, Nov 15, 2012 at 8:05 PM, viresh kumar <viresh.kumar@linaro.org> wrote:
> > On Thu, Nov 15, 2012 at 7:50 PM, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> >> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> >
> >> +static inline bool is_slave_direction(enum dma_transfer_direction direction)
> >> +{
> >> + return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM);
> >> +}
> >
> > I would add this in dmaengine.h and will also include check for DMA_DEV_TO_DEV.
>
> Also, what about is_slave_xfer() name?
No objections.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2012-11-15 15:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 14:20 [PATCH 1/2] dw_dmac: check direction properly in dw_dma_cyclic_prep Andy Shevchenko
2012-11-15 14:20 ` [PATCH 2/2] dw_dmac: make usage of dw_dma_slave optional Andy Shevchenko
2012-11-15 14:58 ` viresh kumar
2012-11-15 15:21 ` Andy Shevchenko
2012-11-15 15:24 ` Viresh Kumar
2012-11-15 15:27 ` Andy Shevchenko
2012-11-15 15:38 ` Viresh Kumar
2012-11-15 17:58 ` Andy Shevchenko
2012-11-16 4:29 ` Viresh Kumar
2012-11-16 12:37 ` Andy Shevchenko
2012-11-15 14:35 ` [PATCH 1/2] dw_dmac: check direction properly in dw_dma_cyclic_prep viresh kumar
2012-11-15 14:58 ` viresh kumar
2012-11-15 15:17 ` Andy Shevchenko [this message]
2012-11-16 12:37 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352992647.11158.334.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spear-devel@list.st.com \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox