From: Joe Perches <joe@perches.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jingoo Han <jg1.han@samsung.com>,
Andy Whitcroft <apw@canonical.com>,
peter@hurleysoftware.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: extend line continuation test
Date: Thu, 15 Nov 2012 23:09:55 -0800 [thread overview]
Message-ID: <1353049795.24310.35.camel@joe-AO722> (raw)
In-Reply-To: <CAMuHMdVxZqQLK4cKD7oYj31c-=LoBsaaoTQTqJcHg-nzg2iG_w@mail.gmail.com>
On Fri, 2012-11-16 at 08:02 +0100, Geert Uytterhoeven wrote:
> On Fri, Nov 16, 2012 at 7:21 AM, Joe Perches <joe@perches.com> wrote:
> > Preprocessor directives and asm statements should be
> > allowed to have a line continuation.
>
> For preprocessor directives I agree.
>
> But why do asm statements need it? They'r just strings, so just closing with
> a double quote at the end of the first line, and opening again with a
> double quote
> on the next line works fine.
I agree it does, but it's a pretty common existing style and
I want to avoid people submitting unnecessary "fix" patches.
next prev parent reply other threads:[~2012-11-16 7:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121030211530.09F1320004E@hpza10.eem.corp.google.com>
2012-11-16 6:21 ` [PATCH] checkpatch: extend line continuation test Joe Perches
2012-11-16 6:28 ` Jingoo Han
2012-11-16 7:02 ` Geert Uytterhoeven
2012-11-16 7:09 ` Joe Perches [this message]
2012-11-16 19:31 ` [PATCH V2] " Joe Perches
2012-11-19 1:06 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353049795.24310.35.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=geert@linux-m68k.org \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox