From: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>
To: dhowells@redhat.com
Cc: linux-kernel@vger.kernel.org, jlee@suse.com
Subject: [PATCH] sign-file: fix the perl warning message when extracting ASN.1
Date: Tue, 20 Nov 2012 18:46:18 +0800 [thread overview]
Message-ID: <1353408378-17496-1-git-send-email-jlee@suse.com> (raw)
There have the following warning message when running modules install for sign ko files:
# make modules_install
...
INSTALL drivers/input/touchscreen/pcap_ts.ko
Found = in conditional, should be == at scripts/sign-file line 164.
Found = in conditional, should be == at scripts/sign-file line 161.
Found = in conditional, should be == at scripts/sign-file line 159.
This patch change replace '=' by '==' in elsif conditions for avoid the above warning messages.
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
scripts/sign-file | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/sign-file b/scripts/sign-file
index 87ca59d..974a20b 100755
--- a/scripts/sign-file
+++ b/scripts/sign-file
@@ -156,12 +156,12 @@ sub asn1_extract($$@)
if ($l == 0x1) {
$len = unpack("C", substr(${$cursor->[2]}, $cursor->[0], 1));
- } elsif ($l = 0x2) {
+ } elsif ($l == 0x2) {
$len = unpack("n", substr(${$cursor->[2]}, $cursor->[0], 2));
- } elsif ($l = 0x3) {
+ } elsif ($l == 0x3) {
$len = unpack("C", substr(${$cursor->[2]}, $cursor->[0], 1)) << 16;
$len = unpack("n", substr(${$cursor->[2]}, $cursor->[0] + 1, 2));
- } elsif ($l = 0x4) {
+ } elsif ($l == 0x4) {
$len = unpack("N", substr(${$cursor->[2]}, $cursor->[0], 4));
} else {
die $x509, ": ", $cursor->[0], ": ASN.1 element too long (", $l, ")\n";
--
1.6.0.2
next reply other threads:[~2012-11-20 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 10:46 Lee, Chun-Yi [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-11-21 11:26 [PATCH] sign-file: fix the perl warning message when extracting ASN.1 David Howells
2012-11-21 11:40 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353408378-17496-1-git-send-email-jlee@suse.com \
--to=joeyli.kernel@gmail.com \
--cc=dhowells@redhat.com \
--cc=jlee@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox