From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Feng Tang <feng.tang@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>, Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [PATCH 1/3] perf session: Add perf_session__delete_env
Date: Wed, 21 Nov 2012 00:20:54 +0900 [thread overview]
Message-ID: <1353424854.1512.5.camel@leonhard> (raw)
In-Reply-To: <20121120151344.GA14928@infradead.org>
2012-11-20 (화), 12:13 -0300, Arnaldo Carvalho de Melo:
> Em Tue, Nov 20, 2012 at 05:31:15PM +0800, Feng Tang escreveu:
> > +static void perf_session__delete_env(struct perf_session *self)
> > +{
> > + struct perf_session_env *env = &self->header.env;
> > +
> > + free(env->hostname);
> > + free(env->os_release);
> > + free(env->version);
> > + free(env->arch);
> > + free(env->cpu_desc);
> > + free(env->cpuid);
> > +
> > + free(env->cmdline);
> > + free(env->sibling_cores);
> > + free(env->sibling_threads);
> > + free(env->numa_nodes);
> > + free(env->pmu_mappings);
> > +}
>
> The object being deleted is a perf_session_env, so please make it
> perf_session_env__delete(struct perf_session_env *env), and avoid using
> 'self'.
Okay, will do.
Thanks,
Namhyung
next prev parent reply other threads:[~2012-11-20 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 9:31 [PATCH 1/3] perf session: Add perf_session__delete_env Feng Tang
2012-11-20 9:31 ` [PATCH 2/3] perf hists browser: Add option for runtime switching perf data file Feng Tang
2012-11-20 15:16 ` Arnaldo Carvalho de Melo
2012-11-20 16:16 ` Feng Tang
2012-11-20 16:24 ` Feng Tang
2012-11-20 9:31 ` [PATCH 3/3] perf report: Enable the runtime switching of " Feng Tang
2012-11-20 15:13 ` [PATCH 1/3] perf session: Add perf_session__delete_env Arnaldo Carvalho de Melo
2012-11-20 15:20 ` Namhyung Kim [this message]
2012-11-21 4:43 ` [PATCH v2 1/3] perf session: Free environment information when deleting session Namhyung Kim
2013-01-24 18:39 ` [tip:perf/core] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353424854.1512.5.camel@leonhard \
--to=namhyung@kernel.org \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=feng.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox