2.4.5 -ac series broken on Sparc64

2.4.5 -ac series broken on Sparc64

[Leif Sawyer]

i've successfully built the 2.4.5 vanilla kernel.

I went to check the -ac series, and each [1-4] breaks
in the same way on Sparc64 platform:

include/linux/irq.h:61: asm/hw_irq.h: No such file or directory
*** [sched.o] Error 1

a find . -name 'hw_irq.h' shows appropriate versions
in i386, ia64, mips, mips64, alpha, ppc, parisc, um, and sh

Is this is a ports-maintainer issue, or what?  Surely
breaking the sparc platform is not in the future plans...

Thanks.

Re: 2.4.5 -ac series broken on Sparc64

[Keith Owens]

On Tue, 29 May 2001 16:30:46 -0800, 
Leif Sawyer <lsawyer@gci.com> wrote:
>include/linux/irq.h:61: asm/hw_irq.h: No such file or directory
>*** [sched.o] Error 1

You must run make {old,menu,x}config first to define the asm -> asm-$(ARCH)
symlink.

Re: 2.4.5 -ac series broken on Sparc64

[Keith Owens]

On Tue, 29 May 2001 16:30:46 -0800, 
Leif Sawyer <lsawyer@gci.com> wrote:
>I went to check the -ac series, and each [1-4] breaks
>in the same way on Sparc64 platform:
>
>include/linux/irq.h:61: asm/hw_irq.h: No such file or directory
>*** [sched.o] Error 1

Ignore previous message, -ENOTENOUGHCOFFEE.  There is no sparc version
of hw_irq.h, not even in DaveM's tree.

Re: 2.4.5 -ac series broken on Sparc64

[Alan Cox]

> I went to check the -ac series, and each [1-4] breaks
> in the same way on Sparc64 platform:

Well I don't guarantee they will.

> include/linux/irq.h:61: asm/hw_irq.h: No such file or directory
> *** [sched.o] Error 1
> 
> a find . -name 'hw_irq.h' shows appropriate versions
> in i386, ia64, mips, mips64, alpha, ppc, parisc, um, and sh
> 
> Is this is a ports-maintainer issue, or what?  Surely
> breaking the sparc platform is not in the future plans...

The sparc64 tree isnt very well integrated with -ac. What I have I merge but
where -ac varies from the Linus tree or the Linus tree requires new files
tends to break it.

It can probably be an empty file

RE: 2.4.5 -ac series broken on Sparc64

[Leif Sawyer]

Alan Cox responded to:
> Leif Sawyer, who wrote:
>> include/linux/irq.h:61: asm/hw_irq.h: No such file or directory
>> *** [sched.o] Error 1
>> 
>> a find . -name 'hw_irq.h' shows appropriate versions
>> in i386, ia64, mips, mips64, alpha, ppc, parisc, um, and sh
>> 
> The sparc64 tree isnt very well integrated with -ac. What I 
> have I merge but where -ac varies from the Linus tree or the
> Linus tree  requires new files tends to break it.
> 
> It can probably be an empty file

This worked for me:

sed 's/_SH_/_SPARC64_/g' include/asm-sh/hw_irq.h >
include/asm-sparc64/hw_irq.h

make mrproper
cp ../.config .
make oldconfig
make dep && make

In file included from /usr/src/linux-2.4.5-ac4/include/linux/sched.h:9
/usr/src/linux-2.4.5-ac4/include/linux/binfmts.h:45: warning: `struct
mm_struct' declared inside parameter list
/usr/src/linux-2.4.5-ac4/include/linux/binfmts.h:45: warning: its scope is
only this definition or declaration,
/usr/src/linux-2.4.5-ac4/include/linux/binfmts.h:45: warning: which is
probably not what you want.

This warning is repeated for quite a good portion of the source files during
the make process, however the kernel seems to build correctly.  Haven't
tried a reboot though.. :-\

Re: 2.4.5 -ac series broken on Sparc64

[Russell King]

On Wed, May 30, 2001 at 08:58:19AM +0100, Alan Cox wrote:
> > include/linux/irq.h:61: asm/hw_irq.h: No such file or directory
> > *** [sched.o] Error 1
> 
> The sparc64 tree isnt very well integrated with -ac. What I have I merge but
> where -ac varies from the Linus tree or the Linus tree requires new files
> tends to break it.
> 
> It can probably be an empty file

I've had reports of this on the ARM tree.  I've always taken the view that
if a driver is including linux/irq.h, then it is buggy.  It has no business
including that file - it only contains structures and definitions relating
to architecture specific code.

In Linus' tree, the only reference outside arch code to linux/irq.h is:

drivers/pcmcia/hd64465_ss.c:#include <linux/irq.h>

and it'd be good to get rid of that one as well, but AFAICS this is a
sh specific driver.

Please, lets not make it compulsary for architectures to implement the irq
handling described in linux/irq.h.

--
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

Re: 2.4.5 -ac series broken on Sparc64

[Alan Cox]

> In Linus' tree, the only reference outside arch code to linux/irq.h is:
> 
> drivers/pcmcia/hd64465_ss.c:#include <linux/irq.h>
> 
> and it'd be good to get rid of that one as well, but AFAICS this is a
> sh specific driver.

Yep

> Please, lets not make it compulsary for architectures to implement the irq
> handling described in linux/irq.h.

Seems reasonable