From: Stephane Eranian <eranian@google.com>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com,
acme@redhat.com, jolsa@redhat.com, namhyung.kim@lge.com,
Namhyung Kim <namhyung@kernel.org>
Subject: [PATCH v3 19/19] perf tools: Fix output of symbol_daddr offset
Date: Wed, 21 Nov 2012 13:49:45 +0100 [thread overview]
Message-ID: <1353502185-26521-20-git-send-email-eranian@google.com> (raw)
In-Reply-To: <1353502185-26521-1-git-send-email-eranian@google.com>
From: Namhyung Kim <namhyung.kim@lge.com>
The symbol addresses in a dso have relative offsets from the start of
a mapping. So in order to ouput correct offset value from @ip, one of
them should be converted.
Cc: Stephane Eranian <eranian@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/sort.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index e2e466d..166480c 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -186,7 +186,7 @@ static int _hist_entry__sym_snprintf(struct map *map, struct symbol *sym,
if (map->type == MAP__VARIABLE) {
ret += repsep_snprintf(bf + ret, size - ret, "%s", sym->name);
ret += repsep_snprintf(bf + ret, size - ret, "+0x%llx",
- ip - sym->start);
+ ip - map->unmap_ip(map, sym->start));
ret += repsep_snprintf(bf + ret, size - ret, "%-*s",
width - ret, "");
} else {
--
1.7.9.5
prev parent reply other threads:[~2012-11-21 12:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 12:49 [PATCH v3 00/16] perf: add memory access sampling support Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 01/19] perf, x86: Support CPU specific sysfs events Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 02/19] perf/x86: improve sysfs event mapping with event string Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 03/19] perf/x86: add flags to event constraints Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 04/19] perf, core: Add a concept of a weightened sample Stephane Eranian
2012-11-28 15:23 ` Jiri Olsa
2012-11-28 15:27 ` Andi Kleen
2012-11-21 12:49 ` [PATCH v3 05/19] perf: add minimal support for PERF_SAMPLE_WEIGHT Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 06/19] perf: add support for PERF_SAMPLE_ADDR in dump_sampple() Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 07/19] perf: add generic memory sampling interface Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 08/19] perf/x86: add memory profiling via PEBS Load Latency Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 09/19] perf/x86: export PEBS load latency threshold register to sysfs Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 10/19] perf/x86: add support for PEBS Precise Store Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 11/19] perf tools: add mem access sampling core support Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 12/19] perf report: add support for mem access profiling Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 13/19] perf record: " Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 14/19] perf tools: add new mem command for memory " Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 15/19] perf: add PERF_RECORD_MISC_MMAP_DATA to RECORD_MMAP Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 16/19] perf tools: detect data vs. text mappings Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 17/19] perf tools: Synthesize data mmap events for threads Stephane Eranian
2012-11-21 12:49 ` [PATCH v3 18/19] perf tools: Ignore ABS symbols when loading data maps Stephane Eranian
2013-01-24 18:44 ` [tip:perf/core] perf symbols: " tip-bot for Namhyung Kim
2012-11-21 12:49 ` Stephane Eranian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353502185-26521-20-git-send-email-eranian@google.com \
--to=eranian@google.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox