Re: [PATCH] PAG support only

David Howells
2003-05-14T08:05:14Z

Christoph Hellwig wrote:

> Please split this into 2 lines as per Documentation/CodingStyle. Even better
> make vfs_token_put handle a NULL argument.

Done the latter.

> Random whitespace change

Gone.

> - and even a wrong one..

I disagree, but no matter.

> > +static kmem_cache_t *vfs_token_cache;
> > +static kmem_cache_t *vfs_pag_cache;
>
> How many of those will be around for a typical AFS client? I have the vague
> feeling the slabs are overkill..

And then there's the people who said I shouldn't use kmalloc but should create
a slab instead...

> > + if (pag>0) {
> > + /* join existing PAG */
> > + if (tsk->vfspag->pag &&
> > + tsk->vfspag->pag==pag)
> > + return pag;
>
> Please try to get your code in conformance with Documentation/CodingStyle.

You are suggesting what changes exactly?

David