Re: [PATCH] PAG support only

Christoph Hellwig
2003-05-14T08:28:24Z

On Wed, May 14, 2003 at 09:17:43AM +0100, David Howells wrote:
> > - and even a wrong one..
>
> I disagree, but no matter.

It's not a matter of your (or my) personal opinion of coding style. Linux
is a big project and it's only maintainable if everyone sticks to a slightly
similar style.

> > > +static kmem_cache_t *vfs_token_cache;
> > > +static kmem_cache_t *vfs_pag_cache;
> >
> > How many of those will be around for a typical AFS client? I have the vague
> > feeling the slabs are overkill..
>
> And then there's the people who said I shouldn't use kmalloc but should create
> a slab instead...

That's why I ask how much it is used. Could you answer the question maybe?

>
> > > + if (pag>0) {
> > > + /* join existing PAG */
> > > + if (tsk->vfspag->pag &&
> > > + tsk->vfspag->pag==pag)
> > > + return pag;
> >
> > Please try to get your code in conformance with Documentation/CodingStyle.
>
> You are suggesting what changes exactly?

spaces between operators to start with. It's not that difficult to read the
above document and other core kernel code, though.