Re: [Patch v3 3/7] rtc: DA9055 RTC driver

[Ashish Jangam <ashish.jangam@kpitcummins.com>]

On Tue, 2012-11-27 at 14:23 -0800, Andrew Morton wrote:
> On Fri, 23 Nov 2012 15:41:03 +0530
> Ashish Jangam <ashish.jangam@kpitcummins.com> wrote:
> 
> > On Tue, 2012-10-23 at 15:33 +0530, Ashish Jangam wrote:
> > > Does this patch looks good?
> > > On Thu, 2012-10-11 at 16:10 +0530, Ashish Jangam wrote:
> > > > This is the RTC patch for the DA9055 PMIC. This patch has got dependency on
> > > > the DA9055 MFD core.
> > > > 
> > > > This patch is functionally tested on Samsung SMDKV6410.
> > > > 
> > >
> 
> (Top-posting repaired. Please don't top-post).
> 
> > Any comments on this patch.
> 
> "shubhro <omaplinuxkernel@gmail.com>" made a comment, but it was ignored:
> 
> : On Thu, 11 Oct 2012 16:53:34 +0530
> : shubhro <omaplinuxkernel@gmail.com> wrote:
> : 
> : > On Thursday 11 October 2012 04:10 PM, Ashish Jangam wrote:
> : > > +#define da9055_rtc_freeze NULL
> : > > +#endif
> : > > +
> : > > +static const struct dev_pm_ops da9055_rtc_pm_ops = {
> : > > +	.suspend = da9055_rtc_suspend,
> : > > +	.resume = da9055_rtc_resume,
> : > > +
> : > > +	.freeze = da9055_rtc_freeze,
> : > > +	.thaw = da9055_rtc_resume,
> : > > +	.restore = da9055_rtc_resume,
> : > > +
> : > > +	.poweroff = da9055_rtc_suspend,
> : > > +};
> : > You may want to use simple dev pm ops
> 
> 
>