Re: [PATCH 19/28] Drivers: hv: Add code to distribute channel interrupt load

Greg KH
2013-01-17T19:38:40Z

On Sat, Dec 01, 2012 at 06:46:50AM -0800, K. Y. Srinivasan wrote:
> +/*
> + * This is an array of channels (devices) that are performance critical.
> + * We attempt to distribute the interrupt load for these devices across
> + * all available CPUs.
> + */
> +static const uuid_le hp_devs[] = {
> + /* {32412632-86cb-44a2-9b5c-50d1417354f5} */
> + /* IDE */
> + {
> + .b = {
> + 0x32, 0x26, 0x41, 0x32, 0xcb, 0x86, 0xa2, 0x44,
> + 0x9b, 0x5c, 0x50, 0xd1, 0x41, 0x73, 0x54, 0xf5
> + }
> + },
> + /* {ba6163d9-04a1-4d29-b605-72e2ffb1dc7f} */
> + /* Storage - SCSI */
> + {
> + .b = {
> + 0xd9, 0x63, 0x61, 0xba, 0xa1, 0x04, 0x29, 0x4d,
> + 0xb6, 0x05, 0x72, 0xe2, 0xff, 0xb1, 0xdc, 0x7f
> + }
> + },
> + /* {F8615163-DF3E-46c5-913F-F2D2F965ED0E} */
> + /* Network */
> + {
> + .b = {
> + 0x63, 0x51, 0x61, 0xF8, 0x3E, 0xDF, 0xc5, 0x46,
> + 0x91, 0x3F, 0xF2, 0xD2, 0xF9, 0x65, 0xED, 0x0E
> + }
> + },
> +
> +};

You are now duplicating these "ids" in different places in the kernel,
perhaps you should put them in one place (hyperv.h?) and then reference
them that way? It's like a device id for pci, once you use it in two
places, it goes into pci_ids.h.

I'm not going to reject this patch, but can you please do this in a
follow-on patch?

thanks,

greg k-h