* [PATCH] tools:virtio: fix compilation warning
@ 2012-12-03 10:24 Cong Ding
2012-12-03 11:01 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Cong Ding @ 2012-12-03 10:24 UTC (permalink / raw)
To: Rusty Russell, mst, Christoph Hellwig; +Cc: linux-kernel, Cong Ding
We do not allow old-style function definition. Always spell foo(void) if
a function does not take any parameters.
Signed-off-by: Cong Ding <dinggnu@gmail.com>
---
tools/virtio/virtio_test.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
index e626fa5..6d25dcd 100644
--- a/tools/virtio/virtio_test.c
+++ b/tools/virtio/virtio_test.c
@@ -232,7 +232,7 @@ const struct option longopts[] = {
}
};
-static void help()
+static void help(void)
{
fprintf(stderr, "Usage: virtio_test [--help]"
" [--no-indirect]"
--
1.7.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tools:virtio: fix compilation warning
2012-12-03 10:24 [PATCH] tools:virtio: fix compilation warning Cong Ding
@ 2012-12-03 11:01 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2012-12-03 11:01 UTC (permalink / raw)
To: Cong Ding; +Cc: Rusty Russell, Christoph Hellwig, linux-kernel
On Mon, Dec 03, 2012 at 10:24:54AM +0000, Cong Ding wrote:
> We do not allow old-style function definition. Always spell foo(void) if
> a function does not take any parameters.
>
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
Thanks, applied.
> ---
> tools/virtio/virtio_test.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
> index e626fa5..6d25dcd 100644
> --- a/tools/virtio/virtio_test.c
> +++ b/tools/virtio/virtio_test.c
> @@ -232,7 +232,7 @@ const struct option longopts[] = {
> }
> };
>
> -static void help()
> +static void help(void)
> {
> fprintf(stderr, "Usage: virtio_test [--help]"
> " [--no-indirect]"
> --
> 1.7.4.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-03 10:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-03 10:24 [PATCH] tools:virtio: fix compilation warning Cong Ding
2012-12-03 11:01 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox