From: Alex Shi <alex.shi@intel.com>
To: npiggin@kernel.dk, mingo@redhat.com, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: [PATCH 01/10] sched: select_task_rq_fair clean up
Date: Mon, 3 Dec 2012 21:54:05 +0800 [thread overview]
Message-ID: <1354542848-29638-2-git-send-email-alex.shi@intel.com> (raw)
In-Reply-To: <1354542848-29638-1-git-send-email-alex.shi@intel.com>
It is impossible to miss a task allowed cpu in a eligible group.
And since find_idlest_group only return a different group which
excludes old cpu, it's also imporissible to find a new cpu same as old
cpu.
Signed-off-by: Alex Shi <alex.shi@intel.com>
---
kernel/sched/fair.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 59e072b..df99456 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3150,11 +3150,6 @@ select_task_rq_fair(struct task_struct *p, int sd_flag, int wake_flags)
}
new_cpu = find_idlest_cpu(group, p, cpu);
- if (new_cpu == -1 || new_cpu == cpu) {
- /* Now try balancing at a lower domain level of cpu */
- sd = sd->child;
- continue;
- }
/* Now try balancing at a lower domain level of new_cpu */
cpu = new_cpu;
--
1.7.5.4
next prev parent reply other threads:[~2012-12-03 13:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 13:54 [PATCH 0/4] sched: fork/exec/wake clean up Alex Shi
2012-12-03 13:54 ` Alex Shi [this message]
2012-12-06 17:50 ` [PATCH 01/10] sched: select_task_rq_fair " Frederic Weisbecker
2012-12-07 0:31 ` Alex Shi
2012-12-07 1:02 ` Frederic Weisbecker
2012-12-07 1:22 ` Alex Shi
2012-12-03 13:54 ` [PATCH 02/10] sched: fix find_idlest_group mess logical Alex Shi
2012-12-07 0:56 ` Frederic Weisbecker
2012-12-07 1:32 ` Alex Shi
2012-12-07 8:33 ` Frederic Weisbecker
2012-12-08 12:12 ` Alex Shi
2012-12-03 13:54 ` [PATCH 03/10] sched: don't need go to smaller sched domain Alex Shi
2012-12-03 13:54 ` [PATCH 04/10] sched: remove domain iterations in fork/exec/wake Alex Shi
2012-12-05 7:09 ` [PATCH 0/4] sched: fork/exec/wake clean up Alex Shi
2012-12-07 0:33 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354542848-29638-2-git-send-email-alex.shi@intel.com \
--to=alex.shi@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=npiggin@kernel.dk \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).