From: Joe Perches <joe@perches.com>
To: "Ortiz, Lance E" <lance.oritz@hp.com>
Cc: "bhelgaas@google.com" <bhelgaas@google.com>,
"lance_ortiz@hotmail.com" <lance_ortiz@hotmail.com>,
"jiang.liu@huawei.com" <jiang.liu@huawei.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"bp@alien8.de" <bp@alien8.de>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"mchehab@redhat.com" <mchehab@redhat.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/3] aerdrv: Trace Event for AER
Date: Mon, 03 Dec 2012 12:26:33 -0800 [thread overview]
Message-ID: <1354566393.3524.9.camel@joe-AO722> (raw)
In-Reply-To: <A961433CDFF2F640A2866803152E61F9516EE733@G4W3218.americas.hpqcorp.net>
On Mon, 2012-12-03 at 20:20 +0000, Ortiz, Lance E wrote:
> > > +#define correctable_error_string \
> > > + {BIT(0), "Receiver Error"}, \
> > > + {BIT(6), "Bad TLP"}, \
> > > + {BIT(7), "Bad DLLP"}, \
> > > + {BIT(8), "RELAY_NUM Rollover"}, \
> > > + {BIT(12), "Replay Timer Timeout"}, \
> > > + {BIT(13), "Advisory Non-Fatal"}
> > > +
> > > +#define uncorrectable_error_string \
> > > + {BIT(4), "Data Link Protocol"}, \
> > > + {BIT(12), "Poisoned TLP"}, \
> > > + {BIT(13), "Flow Control Protocol"}, \
> > > + {BIT(14), "Completion Timeout"}, \
> > > + {BIT(15), "Completer Abort"}, \
> > > + {BIT(16), "Unexpected Completion"}, \
> > > + {BIT(17), "Receiver Overflow"}, \
> > > + {BIT(18), "Malformed TLP"}, \
> > > + {BIT(19), "ECRC"}, \
> > > + {BIT(20), "Unsupported Request"}
> >
> > probably better to prefix these with aer_
>
> If I add aer_ it will conflict with string array in aerdrv_errprint.c
Maybe just not something quite so generic.
maybe aer_trace_correctable and aer_trace_uncorrectable
cheers, Joe
prev parent reply other threads:[~2012-12-03 20:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 18:33 [PATCH v4 1/3] aerdrv: Trace Event for AER Lance Ortiz
2012-12-03 18:33 ` [PATCH v4 2/3] aerdrv: Enhanced AER logging Lance Ortiz
2012-12-03 18:33 ` [PATCH v4 3/3] aerdrv: Cleanup log output for CPER based AER Lance Ortiz
2012-12-03 18:50 ` [PATCH v4 1/3] aerdrv: Trace Event for AER Borislav Petkov
2012-12-03 19:58 ` Ortiz, Lance E
2012-12-03 19:51 ` Joe Perches
2012-12-03 20:20 ` Ortiz, Lance E
2012-12-03 20:26 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354566393.3524.9.camel@joe-AO722 \
--to=joe@perches.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=jiang.liu@huawei.com \
--cc=lance.oritz@hp.com \
--cc=lance_ortiz@hotmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox