From: Przemo Firszt <przemo@firszt.eu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
greg@kroah.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] rtl8712: replace min with min_t
Date: Mon, 10 Dec 2012 23:20:42 +0000 [thread overview]
Message-ID: <1355181642.2897.27.camel@localhost> (raw)
In-Reply-To: <20121210224943.GT22569@mwanda>
Dnia 2012-12-11, wto o godzinie 01:49 +0300, Dan Carpenter pisze:
[..]
> At the end iwe.u.data.length is going to be a number between 0 and
> 32. That can easily fit in 16 bits no problem.
>
> The difference is that, imagine ->network.Ssid.SsidLength is larger
> than u16 like 0x10001. The cast to u16 changes it to 0x0001 which
> is less than 32 so we would say the minimum is 1 when actually we
> want to say 32 is the min.
>
Dan,
Thank you! That was the thing that I missed...
New set of patches on the way.
--
Kind regards,
Przemo Firszt
next prev parent reply other threads:[~2012-12-10 23:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-09 10:15 [PATCH 1/5] rtl8712: code clean up Przemo Firszt
2012-12-09 10:15 ` [PATCH 2/5] rtl8712: remove unused macros from rtl8712/wifi.h Przemo Firszt
2012-12-09 10:15 ` [PATCH 3/5] rtl8712: replace printk with better solutions Przemo Firszt
2012-12-09 11:47 ` Joe Perches
2012-12-09 10:15 ` [PATCH 4/5] rtl8712: replace min with min_t Przemo Firszt
2012-12-10 9:41 ` Dan Carpenter
2012-12-10 22:21 ` Przemo Firszt
2012-12-10 22:49 ` Dan Carpenter
2012-12-10 23:20 ` Przemo Firszt [this message]
2012-12-09 10:15 ` [PATCH 5/5] rtl8712: replace leading spaces with tab Przemo Firszt
2012-12-10 9:46 ` Dan Carpenter
2012-12-10 11:49 ` Joe Perches
2012-12-10 12:21 ` Dan Carpenter
2012-12-10 13:47 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355181642.2897.27.camel@localhost \
--to=przemo@firszt.eu \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).