From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752686Ab2LKDsQ (ORCPT ); Mon, 10 Dec 2012 22:48:16 -0500 Received: from mail-ie0-f169.google.com ([209.85.223.169]:37467 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751867Ab2LKDsP (ORCPT ); Mon, 10 Dec 2012 22:48:15 -0500 X-Greylist: delayed 5619 seconds by postgrey-1.27 at vger.kernel.org; Mon, 10 Dec 2012 22:48:14 EST Message-ID: <1355197690.1933.20.camel@kernel.cn.ibm.com> Subject: Re: [PATCH V2] MCE: fix an error of mce_bad_pages statistics From: Simon Jeons To: Andi Kleen Cc: Xishi Qiu , Wanpeng Li , Andrew Morton , WuJianguo , Liujiang , Vyacheslav.Dubeyko@huawei.com, Borislav Petkov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, wency@cn.fujitsu.com Date: Mon, 10 Dec 2012 21:48:10 -0600 In-Reply-To: <20121211031907.GZ16230@one.firstfloor.org> References: <20121210083342.GA31670@hacker.(null)> <50C5A62A.6030401@huawei.com> <1355136423.1700.2.camel@kernel.cn.ibm.com> <50C5C4A2.2070002@huawei.com> <20121210153805.GS16230@one.firstfloor.org> <1355190540.1933.4.camel@kernel.cn.ibm.com> <20121211020313.GV16230@one.firstfloor.org> <1355192071.1933.7.camel@kernel.cn.ibm.com> <20121211030125.GY16230@one.firstfloor.org> <1355195591.1933.18.camel@kernel.cn.ibm.com> <20121211031907.GZ16230@one.firstfloor.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.1 (3.4.1-2.fc17) Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2012-12-11 at 04:19 +0100, Andi Kleen wrote: > On Mon, Dec 10, 2012 at 09:13:11PM -0600, Simon Jeons wrote: > > On Tue, 2012-12-11 at 04:01 +0100, Andi Kleen wrote: > > > > Oh, it will be putback to lru list during migration. So does your "some > > > > time" mean before call check_new_page? > > > > > > Yes until the next check_new_page() whenever that is. If the migration > > > works it will be earlier, otherwise later. > > > > But I can't figure out any page reclaim path check if the page is set > > PG_hwpoison, can poisoned pages be rclaimed? > > The only way to reclaim a page is to free and reallocate it. Then why there doesn't have check in reclaim path to avoid relcaim poisoned page? -Simon > > -Andi