From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755950Ab2LLAff (ORCPT ); Tue, 11 Dec 2012 19:35:35 -0500 Received: from mail-wg0-f46.google.com ([74.125.82.46]:53452 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933182Ab2LLAc4 (ORCPT ); Tue, 11 Dec 2012 19:32:56 -0500 From: Cyril Roelandt To: linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, Cyril Roelandt , manjunath.hadli@ti.com, prabhakar.lad@ti.com, mchehab@redhat.com, linux-media@vger.kernel.org, davinci-linux-open-source@linux.davincidsp.com Subject: [PATCH 2/5] media: davinci: fix return value check in vpbe_display_reqbufs(). Date: Wed, 12 Dec 2012 01:24:51 +0100 Message-Id: <1355271894-5284-3-git-send-email-tipecaml@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1355271894-5284-1-git-send-email-tipecaml@gmail.com> References: <1355271894-5284-1-git-send-email-tipecaml@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org vb2_dma_contig_init_ctx() returns ERR_PTR and never returns NULL, so IS_ERR should be used instead of a NULL check. Signed-off-by: Cyril Roelandt --- drivers/media/platform/davinci/vpbe_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/davinci/vpbe_display.c b/drivers/media/platform/davinci/vpbe_display.c index 2bfde79..2db4eff 100644 --- a/drivers/media/platform/davinci/vpbe_display.c +++ b/drivers/media/platform/davinci/vpbe_display.c @@ -1393,7 +1393,7 @@ static int vpbe_display_reqbufs(struct file *file, void *priv, } /* Initialize videobuf queue as per the buffer type */ layer->alloc_ctx = vb2_dma_contig_init_ctx(vpbe_dev->pdev); - if (!layer->alloc_ctx) { + if (IS_ERR(layer->alloc_ctx)) { v4l2_err(&vpbe_dev->v4l2_dev, "Failed to get the context\n"); return -EINVAL; } -- 1.7.10.4