From: Steven Whitehouse <swhiteho@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <trivial@kernel.org>,
cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [TRIVIAL PATCH 19/26] gfs2: Convert print_symbol to %pSR
Date: Thu, 13 Dec 2012 10:57:31 +0000 [thread overview]
Message-ID: <1355396251.2708.8.camel@menhir> (raw)
In-Reply-To: <9e86924627c3e2fa6e45bd07537115a291db50fe.1355335228.git.joe@perches.com>
Hi,
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Steve.
On Wed, 2012-12-12 at 10:19 -0800, Joe Perches wrote:
> Use the new vsprintf extension to avoid any possible
> message interleaving.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> fs/gfs2/glock.c | 4 ++--
> fs/gfs2/trans.c | 3 ++-
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
> index 992c5c0..453978b 100644
> --- a/fs/gfs2/glock.c
> +++ b/fs/gfs2/glock.c
> @@ -1016,11 +1016,11 @@ do_cancel:
> return;
>
> trap_recursive:
> - print_symbol(KERN_ERR "original: %s\n", gh2->gh_ip);
> + printk(KERN_ERR "original: %pSR\n", (void *)gh2->gh_ip);
> printk(KERN_ERR "pid: %d\n", pid_nr(gh2->gh_owner_pid));
> printk(KERN_ERR "lock type: %d req lock state : %d\n",
> gh2->gh_gl->gl_name.ln_type, gh2->gh_state);
> - print_symbol(KERN_ERR "new: %s\n", gh->gh_ip);
> + printk(KERN_ERR "new: %pSR\n", (void *)gh->gh_ip);
> printk(KERN_ERR "pid: %d\n", pid_nr(gh->gh_owner_pid));
> printk(KERN_ERR "lock type: %d req lock state : %d\n",
> gh->gh_gl->gl_name.ln_type, gh->gh_state);
> diff --git a/fs/gfs2/trans.c b/fs/gfs2/trans.c
> index 4136270..3d8aa7f 100644
> --- a/fs/gfs2/trans.c
> +++ b/fs/gfs2/trans.c
> @@ -95,7 +95,8 @@ static void gfs2_log_release(struct gfs2_sbd *sdp, unsigned int blks)
>
> static void gfs2_print_trans(const struct gfs2_trans *tr)
> {
> - print_symbol(KERN_WARNING "GFS2: Transaction created at: %s\n", tr->tr_ip);
> + printk(KERN_WARNING "GFS2: Transaction created at: %pSR\n",
> + (void *)tr->tr_ip);
> printk(KERN_WARNING "GFS2: blocks=%u revokes=%u reserved=%u touched=%d\n",
> tr->tr_blocks, tr->tr_revokes, tr->tr_reserved, tr->tr_touched);
> printk(KERN_WARNING "GFS2: Buf %u/%u Databuf %u/%u Revoke %u/%u\n",
next prev parent reply other threads:[~2012-12-13 10:58 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 18:18 [TRIVIAL PATCH 00/26] treewide: Add and use vsprintf extension %pSR Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 01/26] vsprintf: Add extension %pSR - print_symbol replacement Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 02/26] alpha: Convert print_symbol to %pSR Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 03/26] arm: " Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 04/26] arm64: " Joe Perches
2012-12-13 18:03 ` Catalin Marinas
2012-12-12 18:18 ` [TRIVIAL PATCH 05/26] avr32: " Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 06/26] c6x: " Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 07/26] ia64: " Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 08/26] m32r: " Joe Perches
2012-12-13 3:06 ` Hirokazu Takata
2013-04-29 13:21 ` Jiri Kosina
2013-04-30 12:56 ` Joe Perches
2013-04-30 21:11 ` Jiri Kosina
2012-12-12 18:18 ` [TRIVIAL PATCH 09/26] mn10300: " Joe Perches
2012-12-12 18:18 ` [TRIVIAL PATCH 10/26] openrisc: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 11/26] powerpc: " Joe Perches
2012-12-13 11:58 ` Arnd Bergmann
2013-01-10 5:48 ` Benjamin Herrenschmidt
2013-01-10 17:00 ` Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 12/26] s390: " Joe Perches
2012-12-13 1:22 ` Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 13/26] sh: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 14/26] um: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 15/26] unicore32: " Joe Perches
[not found] ` <001d01cdd8cd$371dfd60$a559f820$@mprc.pku.edu.cn>
2012-12-13 1:21 ` 答复: " Joe Perches
2012-12-13 2:00 ` Chen Gang
2012-12-13 2:26 ` Joe Perches
[not found] ` <19e6ea369e4455fc447c48f72bd433921bd0a703.1355335228.git.joe@perches.c om>
2012-12-13 5:05 ` guanxuetao
2012-12-12 18:19 ` [TRIVIAL PATCH 16/26] x86: " Joe Perches
2012-12-12 21:09 ` Borislav Petkov
2012-12-12 21:30 ` Joe Perches
2012-12-12 21:48 ` Borislav Petkov
2012-12-12 21:49 ` Luck, Tony
2012-12-12 22:23 ` Joe Perches
2012-12-12 22:45 ` Borislav Petkov
2012-12-13 18:23 ` Joe Perches
2012-12-13 18:37 ` Borislav Petkov
2012-12-13 18:42 ` H. Peter Anvin
2012-12-13 19:05 ` Borislav Petkov
2012-12-13 21:35 ` H. Peter Anvin
2012-12-13 18:57 ` Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 17/26] xtensa: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 18/26] drivers: base: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 19/26] gfs2: " Joe Perches
2012-12-13 10:57 ` Steven Whitehouse [this message]
2013-04-29 13:23 ` Jiri Kosina
2012-12-12 18:19 ` [TRIVIAL PATCH 20/26] sysfs: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 21/26] irq: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 22/26] smp_processor_id: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 23/26] mm: " Joe Perches
2012-12-12 20:08 ` Christoph Lameter
2013-04-29 13:24 ` Jiri Kosina
2012-12-12 18:19 ` [TRIVIAL PATCH 24/26] xtensa: " Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 25/26] x86: head_64.S: Use vsprintf extension %pSR not print_symbol Joe Perches
2012-12-12 18:19 ` [TRIVIAL PATCH 26/26] kallsyms: Remove print_symbol Joe Perches
2012-12-12 19:30 ` [TRIVIAL PATCH V2 24/26] Documentation: Convert print_symbol to %pSR Joe Perches
2012-12-13 1:43 ` [TRIVIAL PATCH V2 12/26] s390: " Joe Perches
2012-12-13 19:13 ` [TRIVIAL PATCH V2 16/26] x86: " Joe Perches
2013-01-08 5:52 ` [TRIVIAL PATCH 00/26] treewide: Add and use vsprintf extension %pSR Joe Perches
2013-01-08 20:33 ` Jiri Kosina
2013-02-20 6:00 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355396251.2708.8.camel@menhir \
--to=swhiteho@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox