From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932172Ab2LMS5Q (ORCPT ); Thu, 13 Dec 2012 13:57:16 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:52565 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932121Ab2LMS5O (ORCPT ); Thu, 13 Dec 2012 13:57:14 -0500 Message-ID: <1355425027.13796.31.camel@joe-AO722> Subject: Re: [TRIVIAL PATCH 16/26] x86: Convert print_symbol to %pSR From: Joe Perches To: Borislav Petkov Cc: "Luck, Tony" , Jiri Kosina , Jeff Dike , Richard Weinberger , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "user-mode-linux-devel@lists.sourceforge.net" , "user-mode-linux-user@lists.sourceforge.net" Date: Thu, 13 Dec 2012 10:57:07 -0800 In-Reply-To: <20121213183659.GC31485@liondog.tnic> References: <054f8a88fe46ae0b4c2669d0e155d84c11b66115.1355335228.git.joe@perches.com> <20121212210959.GH8760@liondog.tnic> <1355347803.8538.16.camel@joe-AO722> <3908561D78D1C84285E8C5FCA982C28F1C969495@ORSMSX108.amr.corp.intel.com> <1355351039.27571.2.camel@joe-AO722> <20121212224550.GJ8760@liondog.tnic> <1355422990.13796.9.camel@joe-AO722> <20121213183659.GC31485@liondog.tnic> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.0-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2012-12-13 at 19:37 +0100, Borislav Petkov wrote: > On Thu, Dec 13, 2012 at 10:23:10AM -0800, Joe Perches wrote: > > m->ip is a u64 so, when compiling x86-32, there's a new warning > > "cast to pointer from integer of different size". This isn't new > > different behavior, just a new warning. The previous print_symbol > > took a ulong and the u64 was silently truncated. > > > > CC arch/x86/kernel/cpu/mcheck/mce.o > > arch/x86/kernel/cpu/mcheck/mce.c: In function ‘print_mce’: > > arch/x86/kernel/cpu/mcheck/mce.c:246:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > > > If appropriate, the code could be changed to > > > > (void *)(unsigned long)m->ip > > Can we explicitly cast it to what it is so that we can be explicit as to > what we're casting it? IOW: > > (void *)(__u64)m->ip; > > Does that even work on 32bit? No, it already is __u64. You need (unsigned long) or something else the same size as (void *) from: arch/x86/include/asm/mce.h /* Fields are zero when not available */ struct mce { ... __u64 ip; > Also, does the compiler bitch about this useless cast when building with > W=123? For x86-32: With the cast the line is silent. Without the cast, just the warning about cast.