linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: linux-kernel@vger.kernel.org
Cc: "Bjørn Mork" <bjorn@mork.no>,
	"Norbert Warmuth" <nwarmuth@t-online.de>,
	"Joseph Salisbury" <joseph.salisbury@canonical.com>,
	"Thomas Gleixner" <tglx@linutronix.de>
Subject: [PATCH] Revert "watchdog: Fix CPU hotplug regression"
Date: Fri, 14 Dec 2012 10:34:35 +0100	[thread overview]
Message-ID: <1355477675-10552-1-git-send-email-bjorn@mork.no> (raw)
In-Reply-To: <87y5h1c70y.fsf@nemi.mork.no>

This reverts commit 8d4516904b39507458bee8115793528e12b1d8dd.

commit 8d451690 ("watchdog: Fix CPU hotplug regression") cause
a hard lockup when I connect AC power on my laptop.  The indirect
reason is that laptop-mode-tools is configured to do

  echo 0 > /proc/sys/kernel/nmi_watchdog

when AC power is disconnected and

  echo 1 > /proc/sys/kernel/nmi_watchdog

when AC power is connected.  This is the default configuration of
the Debian laptop-mode-tools package.

Cc: <stable@vger.kernel.org> # v3.7
Cc: Norbert Warmuth <nwarmuth@t-online.de>
Cc: Joseph Salisbury <joseph.salisbury@canonical.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
 kernel/watchdog.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index c8c21be..dd4b80a 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -368,9 +368,6 @@ static void watchdog_disable(unsigned int cpu)
 {
 	struct hrtimer *hrtimer = &__raw_get_cpu_var(watchdog_hrtimer);
 
-	if (!watchdog_enabled)
-		return;
-
 	watchdog_set_prio(SCHED_NORMAL, 0);
 	hrtimer_cancel(hrtimer);
 	/* disable the perf event */
-- 
1.7.2.5


  reply	other threads:[~2012-12-14  9:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-14  9:33 Bisected oops regression between v3.7-rc8 and v3.7: nmi_watchdog Bjørn Mork
2012-12-14  9:34 ` Bjørn Mork [this message]
2012-12-14 13:44 ` [PATCH v2] watchdog: Fix disable/enable regression Bjørn Mork
2012-12-16 19:41 ` Bisected oops regression between v3.7-rc8 and v3.7: nmi_watchdog Maciej Rutecki
2012-12-18  8:13 ` [regression][PATCH v3] watchdog: Fix disable/enable regression Bjørn Mork
2012-12-19 19:51 ` [RESEND][PATCH " Bjørn Mork
2012-12-19 20:13   ` Don Zickus
2012-12-19 21:17     ` Bjørn Mork
2012-12-19 21:44       ` Bjørn Mork
2012-12-20 19:17         ` Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355477675-10552-1-git-send-email-bjorn@mork.no \
    --to=bjorn@mork.no \
    --cc=joseph.salisbury@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nwarmuth@t-online.de \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).