From: Joe Perches <joe@perches.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Jacob Shin <jacob.shin@amd.com>,
Doug Thompson <dougthompson@xmission.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] MCE, AMD: Make MC2 decoding part of amd_decoder_ops as well
Date: Mon, 17 Dec 2012 12:34:35 -0800 [thread overview]
Message-ID: <1355776475.19706.6.camel@joe-AO722> (raw)
In-Reply-To: <20121217202214.GG31866@liondog.tnic>
On Mon, 2012-12-17 at 21:22 +0100, Borislav Petkov wrote:
> On Mon, Dec 17, 2012 at 12:16:16PM -0800, Joe Perches wrote:
> > You also have paths where you start a pr_emerg and do not terminate it
> > when there is no apparent error at all.
>
> For example?
>
decode_mc2_mce does
pr_emerg(HW_ERR "MC2 Error: ");
calls
fam_ops->mc2_mce()
which may not emit anything
and if it doesn't, does
pr_emerg(HW_ERR "Corrupted ...");
on another line leaving a trailing colon without
newline from the pr_emerg above.
I believe the second pr_emerg should be pr_cont
cheers, Joe
next prev parent reply other threads:[~2012-12-17 20:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 19:39 [PATCH 1/2] MCE, AMD: Make MC2 decoding part of amd_decoder_ops as well Jacob Shin
2012-12-17 19:39 ` [PATCH 2/2] MCE, AMD: MCE decoding support for AMD Family 16h Jacob Shin
2012-12-18 17:19 ` Borislav Petkov
2012-12-18 17:30 ` Jacob Shin
2012-12-18 18:09 ` Jacob Shin
2012-12-18 18:32 ` Borislav Petkov
2012-12-18 18:24 ` Joe Perches
2012-12-18 18:33 ` Borislav Petkov
2012-12-18 18:37 ` Joe Perches
2012-12-18 19:00 ` Mauro Carvalho Chehab
2012-12-17 19:57 ` [PATCH 1/2] MCE, AMD: Make MC2 decoding part of amd_decoder_ops as well Joe Perches
2012-12-17 20:05 ` Borislav Petkov
2012-12-17 20:16 ` Joe Perches
2012-12-17 20:22 ` Borislav Petkov
2012-12-17 20:34 ` Joe Perches [this message]
2012-12-17 20:40 ` Borislav Petkov
2012-12-17 20:43 ` Jacob Shin
2012-12-17 20:59 ` Joe Perches
2012-12-17 21:08 ` Borislav Petkov
2012-12-17 21:11 ` Jacob Shin
2012-12-17 21:09 ` Jacob Shin
-- strict thread matches above, loose matches on Subject: below --
2012-12-18 21:06 [PATCH V2 0/2] MCE, AMD: MCE decoding support for AMD Family 16h Jacob Shin
2012-12-18 21:06 ` [PATCH 1/2] MCE, AMD: Make MC2 decoding part of amd_decoder_ops as well Jacob Shin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355776475.19706.6.camel@joe-AO722 \
--to=joe@perches.com \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=jacob.shin@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox