linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@zytor.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH v7 23/27] x86: Don't panic if can not alloc buffer for swiotlb
Date: Mon, 17 Dec 2012 23:15:55 -0800	[thread overview]
Message-ID: <1355814959-10573-24-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1355814959-10573-1-git-send-email-yinghai@kernel.org>

Normal boot path on system with iommu support:
swiotlb buffer will be allocated early at first and then try to initialize
iommu, if iommu for intel or amd could setup properly, swiotlb buffer
will be freed.

The early allocating is with bootmem, and could panic when we try to use
kdump with buffer above 4G only.

Replace the panic with WARN, and the kernel can go on without swiotlb,
and could iommu later.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
 arch/x86/kernel/pci-swiotlb.c |    5 ++++-
 include/linux/swiotlb.h       |    2 +-
 lib/swiotlb.c                 |   15 ++++++++++-----
 3 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/arch/x86/kernel/pci-swiotlb.c b/arch/x86/kernel/pci-swiotlb.c
index 6c483ba..6f93eb7 100644
--- a/arch/x86/kernel/pci-swiotlb.c
+++ b/arch/x86/kernel/pci-swiotlb.c
@@ -91,7 +91,10 @@ IOMMU_INIT(pci_swiotlb_detect_4gb,
 void __init pci_swiotlb_init(void)
 {
 	if (swiotlb) {
-		swiotlb_init(0);
+		if (swiotlb_init(0)) {
+			swiotlb = 0;
+			return;
+		}
 		dma_ops = &swiotlb_dma_ops;
 	}
 }
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index 071d62c..1d2506f 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -22,7 +22,7 @@ extern int swiotlb_force;
  */
 #define IO_TLB_SHIFT 11
 
-extern void swiotlb_init(int verbose);
+int swiotlb_init(int verbose);
 extern void swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose);
 extern unsigned long swiotlb_nr_tbl(void);
 extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs);
diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index 196b069..958322e 100644
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -175,7 +175,7 @@ void __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int verbose)
  * Statically reserve bounce buffer space and initialize bounce buffer data
  * structures for the software IO TLB used to implement the DMA API.
  */
-static void __init
+static int __init
 swiotlb_init_with_default_size(size_t default_size, int verbose)
 {
 	unsigned char *vstart;
@@ -192,16 +192,21 @@ swiotlb_init_with_default_size(size_t default_size, int verbose)
 	 * Get IO TLB memory from the low pages
 	 */
 	vstart = alloc_bootmem_low_pages(PAGE_ALIGN(bytes));
-	if (!vstart)
-		panic("Cannot allocate SWIOTLB buffer");
+	if (!vstart) {
+		WARN(1, "Cannot allocate SWIOTLB buffer");
+		return -1;
+	}
 
 	swiotlb_init_with_tbl(vstart, io_tlb_nslabs, verbose);
+
+	return 0;
 }
 
-void __init
+int __init
 swiotlb_init(int verbose)
 {
-	swiotlb_init_with_default_size(64 * (1<<20), verbose);	/* default to 64MB */
+	/* default to 64MB */
+	return swiotlb_init_with_default_size(64 * (1<<20), verbose);
 }
 
 /*
-- 
1.7.10.4


  parent reply	other threads:[~2012-12-18  7:18 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-18  7:15 [PATCH v7 00/27] x86, boot, 64bit: Add support for loading ramdisk and bzImage above 4G Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 01/27] x86, mm: Fix page table early allocation offset checking Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 02/27] x86, mm: make pgd next calculation consistent with pud/pmd Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 03/27] x86, realmode: set real_mode permissions early Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 04/27] x86, realmode: use init_level4_pgt to set trapmoline_pgt directly Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 05/27] x86, realmode: Separate real_mode reserve and setup Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 06/27] x86, 64bit: early #PF handler set page table Yinghai Lu
2012-12-18 20:43   ` Yinghai Lu
2012-12-18 20:49     ` H. Peter Anvin
2012-12-18 20:55       ` Yinghai Lu
2012-12-18 21:07         ` H. Peter Anvin
2012-12-20 16:56           ` Yinghai Lu
2012-12-25  0:16             ` H. Peter Anvin
2012-12-25  4:04               ` Yinghai Lu
2012-12-25 11:20                 ` Borislav Petkov
2012-12-25 20:51                   ` Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 07/27] x86, 64bit: Print init kernel lowmap correctly Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 08/27] x86: Merge early_reserve_initrd for 32bit and 64bit Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 09/27] x86: add get_ramdisk_image/size() Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 10/27] x86, boot: add get_cmd_line_ptr() Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 11/27] x86, boot: move checking of cmd_line_ptr out of common path Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 12/27] x86, boot: pass cmd_line_ptr with unsigned long Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 13/27] x86, boot: move verify_cpu.S and no_longmode after 0x200 Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 14/27] x86, boot: Move lldt/ltr out of 64bit code section Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 15/27] x86, kexec: remove 1024G limitation for kexec buffer on 64bit Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 16/27] x86, kexec: set ident mapping for kernel that is above max_pfn Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 17/27] x86, kexec: Merge ident_mapping_init and init_level4_page Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 18/27] x86, kexec: only set ident mapping for ram Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 19/27] x86, boot: add fields to support load bzImage and ramdisk above 4G Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 20/27] x86, boot: update comments about entries for 64bit image Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 21/27] x86, boot: Not need to check setup_header version Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 22/27] mm: Add alloc_bootmem_low_pages_nopanic() Yinghai Lu
2012-12-18  7:15 ` Yinghai Lu [this message]
2012-12-18  7:15 ` [PATCH v7 24/27] x86: Add swiotlb force off support Yinghai Lu
2012-12-22  2:37   ` Konrad Rzeszutek Wilk
2012-12-22  2:42     ` Eric W. Biederman
2012-12-22  3:10       ` Konrad Rzeszutek Wilk
2012-12-22  3:23         ` Eric W. Biederman
2012-12-22  3:25           ` H. Peter Anvin
2012-12-22  5:11             ` Yinghai Lu
2012-12-24 23:34               ` H. Peter Anvin
2012-12-24 23:55                 ` Yinghai Lu
2012-12-22 13:21           ` Konrad Rzeszutek Wilk
2012-12-22  5:10       ` Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 25/27] x86, kdump: remove crashkernel range find limit for 64bit Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 26/27] x86: add Crash kernel low reservation Yinghai Lu
2012-12-19 17:22   ` Borislav Petkov
2012-12-19 17:36     ` Yinghai Lu
2012-12-18  7:15 ` [PATCH v7 27/27] x86: Merge early kernel reserve for 32bit and 64bit Yinghai Lu
2012-12-18 22:43 ` [PATCH v7 00/27] x86, boot, 64bit: Add support for loading ramdisk and bzImage above 4G Borislav Petkov
2012-12-18 23:08   ` Yinghai Lu
2012-12-18 23:22     ` Borislav Petkov
2012-12-22  2:42 ` Konrad Rzeszutek Wilk
2012-12-22  3:01   ` H. Peter Anvin
2012-12-22 13:24     ` Konrad Rzeszutek Wilk
2012-12-23  7:29       ` Yinghai Lu
2012-12-23 14:33         ` H. Peter Anvin
2012-12-23 18:00           ` Yinghai Lu
2012-12-23 18:45             ` Borislav Petkov
2012-12-24  4:54               ` H. Peter Anvin
2012-12-24 10:04                 ` Borislav Petkov
2012-12-24 18:44                   ` Yinghai Lu
2012-12-24  4:55               ` H. Peter Anvin
2012-12-24 23:56             ` H. Peter Anvin
2012-12-25 20:57               ` Yinghai Lu
2012-12-25  1:06       ` H. Peter Anvin
2012-12-25 11:52         ` Borislav Petkov
2012-12-25 15:51           ` H. Peter Anvin
2013-01-08 21:08             ` Borislav Petkov
2013-01-08 21:15               ` H. Peter Anvin
2013-01-08 21:19                 ` Borislav Petkov
2013-01-08 23:17                   ` H. Peter Anvin
2013-01-08 23:25                     ` Borislav Petkov
2012-12-22  5:20   ` Yinghai Lu
2012-12-22 13:32     ` Konrad Rzeszutek Wilk
2012-12-22 10:38   ` Yinghai Lu
2012-12-22 13:25     ` Konrad Rzeszutek Wilk
2012-12-22 13:47     ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355814959-10573-24-git-send-email-yinghai@kernel.org \
    --to=yinghai@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).