From: Joe Perches <joe@perches.com>
To: Jacob Shin <jacob.shin@amd.com>
Cc: Borislav Petkov <bp@alien8.de>,
Doug Thompson <dougthompson@xmission.com>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] MCE, AMD: MCE decoding support for AMD Family 16h
Date: Tue, 18 Dec 2012 14:10:59 -0800 [thread overview]
Message-ID: <1355868659.3982.3.camel@joe-AO722> (raw)
In-Reply-To: <1355864771-13839-3-git-send-email-jacob.shin@amd.com>
On Tue, 2012-12-18 at 15:06 -0600, Jacob Shin wrote:
> Add MCE decoding logic for AMD Family 16h processors.
More trivia:
> diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
[]
> @@ -64,6 +64,10 @@ EXPORT_SYMBOL_GPL(to_msgs);
> const char * const ii_msgs[] = { "MEM", "RESV", "IO", "GEN" };
> EXPORT_SYMBOL_GPL(ii_msgs);
>
> +/* internal error type */
> +const char * const uu_msgs[] = { "RESV", "RESV", "HWA", "RESV" };
> +EXPORT_SYMBOL_GPL(uu_msgs);
Do these really need to be exported?
These don't seem to be used outside of mce_amd.
If these really need export, are these very good names?
Perhaps these should be prefixed with something?
next prev parent reply other threads:[~2012-12-18 22:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 21:06 [PATCH V2 0/2] MCE, AMD: MCE decoding support for AMD Family 16h Jacob Shin
2012-12-18 21:06 ` [PATCH 1/2] MCE, AMD: Make MC2 decoding part of amd_decoder_ops as well Jacob Shin
2012-12-18 21:06 ` [PATCH 2/2] MCE, AMD: MCE decoding support for AMD Family 16h Jacob Shin
2012-12-18 22:10 ` Joe Perches [this message]
2012-12-18 22:56 ` Borislav Petkov
2012-12-20 19:20 ` Borislav Petkov
2012-12-20 19:17 ` [PATCH V2 0/2] " Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2012-12-17 19:39 [PATCH 1/2] MCE, AMD: Make MC2 decoding part of amd_decoder_ops as well Jacob Shin
2012-12-17 19:39 ` [PATCH 2/2] MCE, AMD: MCE decoding support for AMD Family 16h Jacob Shin
2012-12-18 17:19 ` Borislav Petkov
2012-12-18 17:30 ` Jacob Shin
2012-12-18 18:09 ` Jacob Shin
2012-12-18 18:32 ` Borislav Petkov
2012-12-18 18:24 ` Joe Perches
2012-12-18 18:33 ` Borislav Petkov
2012-12-18 18:37 ` Joe Perches
2012-12-18 19:00 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355868659.3982.3.camel@joe-AO722 \
--to=joe@perches.com \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=jacob.shin@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox