* 3.8 NFS build breakage with !CONFIG_NFS_FSCACHE
@ 2012-12-21 5:44 Vineet Gupta
2012-12-21 8:33 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Vineet Gupta @ 2012-12-21 5:44 UTC (permalink / raw)
To: David Howells; +Cc: linux-kernel@vger.kernel.org
Hi David,
Not sure if this was report/fixed already - but as of today's Linus tree
(tip has commit 96680d2), I'm seeing a build breakage due to a trivial
missing def for nfs_fscache_wait_on_invalidate.
Following fixes it for me.
diff --git a/fs/nfs/fscache.h b/fs/nfs/fscache.h
index 277b027..4ecb766 100644
--- a/fs/nfs/fscache.h
+++ b/fs/nfs/fscache.h
@@ -222,6 +222,7 @@ static inline void nfs_readpage_to_fscache(struct
inode *inode,
static inline void nfs_fscache_invalidate(struct inode *inode) {}
+static inline void nfs_fscache_wait_on_invalidate(struct inode *inode) {}
Thx,
-Vineet
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: 3.8 NFS build breakage with !CONFIG_NFS_FSCACHE
2012-12-21 5:44 3.8 NFS build breakage with !CONFIG_NFS_FSCACHE Vineet Gupta
@ 2012-12-21 8:33 ` Borislav Petkov
2012-12-21 8:51 ` [PATCH] NFS: Fix compile issue " Vineet Gupta
0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2012-12-21 8:33 UTC (permalink / raw)
To: Vineet Gupta; +Cc: David Howells, linux-kernel@vger.kernel.org
On Fri, Dec 21, 2012 at 11:14:21AM +0530, Vineet Gupta wrote:
> Hi David,
>
> Not sure if this was report/fixed already - but as of today's Linus tree
> (tip has commit 96680d2), I'm seeing a build breakage due to a trivial
> missing def for nfs_fscache_wait_on_invalidate.
>
> Following fixes it for me.
>
> diff --git a/fs/nfs/fscache.h b/fs/nfs/fscache.h
> index 277b027..4ecb766 100644
> --- a/fs/nfs/fscache.h
> +++ b/fs/nfs/fscache.h
> @@ -222,6 +222,7 @@ static inline void nfs_readpage_to_fscache(struct
> inode *inode,
>
>
> static inline void nfs_fscache_invalidate(struct inode *inode) {}
> +static inline void nfs_fscache_wait_on_invalidate(struct inode *inode) {}
I see the same thing here. Please write a proper patch and quote the
build error in the commit message:
fs/nfs/inode.c: In function ‘nfs_invalidate_mapping’:
fs/nfs/inode.c:887:2: error: implicit declaration of function ‘nfs_fscache_wait_on_invalidate’ [-Werror=implicit-function-declaration]
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] NFS: Fix compile issue with !CONFIG_NFS_FSCACHE
2012-12-21 8:33 ` Borislav Petkov
@ 2012-12-21 8:51 ` Vineet Gupta
0 siblings, 0 replies; 3+ messages in thread
From: Vineet Gupta @ 2012-12-21 8:51 UTC (permalink / raw)
To: Trond Myklebust; +Cc: linux-nfs, linux-kernel, Vineet Gupta
fs/nfs/inode.c: In function `nfs_invalidate_mapping`:
fs/nfs/inode.c:887: error: implicit declaration of function
`nfs_fscache_wait_on_invalidate`
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
fs/nfs/fscache.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/nfs/fscache.h b/fs/nfs/fscache.h
index 277b027..4ecb766 100644
--- a/fs/nfs/fscache.h
+++ b/fs/nfs/fscache.h
@@ -222,6 +222,7 @@ static inline void nfs_readpage_to_fscache(struct inode *inode,
static inline void nfs_fscache_invalidate(struct inode *inode) {}
+static inline void nfs_fscache_wait_on_invalidate(struct inode *inode) {}
static inline const char *nfs_server_fscache_state(struct nfs_server *server)
{
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-21 8:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-21 5:44 3.8 NFS build breakage with !CONFIG_NFS_FSCACHE Vineet Gupta
2012-12-21 8:33 ` Borislav Petkov
2012-12-21 8:51 ` [PATCH] NFS: Fix compile issue " Vineet Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).