From: Joonsoo Kim <js1304@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Joonsoo Kim <js1304@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Subject: [PATCH] x86, reboot: skip reboot_fixups in early boot phase
Date: Fri, 28 Dec 2012 22:50:23 +0900 [thread overview]
Message-ID: <1356702623-9430-1-git-send-email-js1304@gmail.com> (raw)
During early boot phase, PCI bus subsystem is not yet initialized.
If panic is occured in early boot phase and panic_timeout is set,
code flow go into emergency_restart() and hit mach_reboot_fixups(), then
encounter another panic. When second panic, we can't hold a panic_lock, so
code flow go into panic_smp_self_stop() which prevent system to restart.
For avoid second panic, skip reboot_fixups in early boot phase.
It makes panic_timeout works in early boot phase.
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Signed-off-by: Joonsoo Kim <js1304@gmail.com>
diff --git a/arch/x86/kernel/reboot_fixups_32.c b/arch/x86/kernel/reboot_fixups_32.c
index c8e41e9..b9b8ec9 100644
--- a/arch/x86/kernel/reboot_fixups_32.c
+++ b/arch/x86/kernel/reboot_fixups_32.c
@@ -89,6 +89,10 @@ void mach_reboot_fixups(void)
if (in_interrupt())
return;
+ /* During early boot phase, PCI is not yet initialized */
+ if (system_state == SYSTEM_BOOTING)
+ return;
+
for (i=0; i < ARRAY_SIZE(fixups_table); i++) {
cur = &(fixups_table[i]);
dev = pci_get_device(cur->vendor, cur->device, NULL);
--
1.7.9.5
next reply other threads:[~2012-12-28 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-28 13:50 Joonsoo Kim [this message]
2013-01-24 17:45 ` [PATCH] x86, reboot: skip reboot_fixups in early boot phase Bjorn Helgaas
2013-01-25 1:13 ` Joonsoo Kim
2013-01-25 2:59 ` Bjorn Helgaas
2013-01-25 4:14 ` Greg Kroah-Hartman
2013-01-25 4:21 ` Bjorn Helgaas
2013-01-25 4:52 ` Greg Kroah-Hartman
2013-01-29 6:03 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356702623-9430-1-git-send-email-js1304@gmail.com \
--to=js1304@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).