linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Alessio Igor Bogani <abogani@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Chris Metcalf <cmetcalf@tilera.com>,
	Christoph Lameter <cl@linux.com>,
	Geoff Levand <geoff@infradead.org>,
	Gilad Ben Yossef <gilad@benyossef.com>,
	Hakan Akkan <hakanakkan@gmail.com>,
	Ingo Molnar <mingo@kernel.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 15/27] sched: Update rq clock earlier in unthrottle_cfs_rq
Date: Sat, 29 Dec 2012 17:42:54 +0100	[thread overview]
Message-ID: <1356799386-4212-16-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1356799386-4212-1-git-send-email-fweisbec@gmail.com>

In this function we are making use of rq->clock right before the
update of the rq clock, let's just call update_rq_clock() just
before that to avoid using a stale rq clock value.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Alessio Igor Bogani <abogani@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Chris Metcalf <cmetcalf@tilera.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Geoff Levand <geoff@infradead.org>
Cc: Gilad Ben Yossef <gilad@benyossef.com>
Cc: Hakan Akkan <hakanakkan@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
 kernel/sched/fair.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index a96f0f2..3d65ac7 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2279,14 +2279,15 @@ void unthrottle_cfs_rq(struct cfs_rq *cfs_rq)
 	long task_delta;
 
 	se = cfs_rq->tg->se[cpu_of(rq_of(cfs_rq))];
-
 	cfs_rq->throttled = 0;
+
+	update_rq_clock(rq);
+
 	raw_spin_lock(&cfs_b->lock);
 	cfs_b->throttled_time += rq->clock - cfs_rq->throttled_clock;
 	list_del_rcu(&cfs_rq->throttled_list);
 	raw_spin_unlock(&cfs_b->lock);
 
-	update_rq_clock(rq);
 	/* update hierarchical throttle state */
 	walk_tg_tree_from(cfs_rq->tg, tg_nop, tg_unthrottle_up, (void *)rq);
 
-- 
1.7.5.4


  parent reply	other threads:[~2012-12-29 16:46 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-29 16:42 [ANNOUNCE] 3.8-rc1-nohz1 Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 01/27] context_tracking: Add comments on interface and internals Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 02/27] cputime: Generic on-demand virtual cputime accounting Frederic Weisbecker
2013-01-04 20:19   ` Paul Gortmaker
2013-01-08 23:54     ` Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 03/27] cputime: Allow dynamic switch between tick/virtual based " Frederic Weisbecker
2013-01-04 22:16   ` Paul Gortmaker
2013-01-07 15:47     ` Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 04/27] cputime: Use accessors to read task cputime stats Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 05/27] cputime: Safely read cputime of full dynticks CPUs Frederic Weisbecker
2012-12-31  5:54   ` Li Zhong
2013-01-04 13:42     ` Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 06/27] nohz: Basic full dynticks interface Frederic Weisbecker
2012-12-31  7:18   ` Li Zhong
2013-01-04 13:24     ` Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 07/27] nohz: Assign timekeeping duty to a non-full-nohz CPU Frederic Weisbecker
2013-01-02 15:30   ` Christoph Lameter
2013-01-04 12:51     ` Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 08/27] nohz: Trace timekeeping update Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 09/27] nohz: Wake up full dynticks CPUs when a timer gets enqueued Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 10/27] rcu: Restart the tick on non-responding full dynticks CPUs Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 11/27] sched: Comment on rq->clock correctness in ttwu_do_wakeup() in nohz Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 12/27] sched: Update rq clock on nohz CPU before migrating tasks Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 13/27] sched: Update rq clock on nohz CPU before setting fair group shares Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 14/27] sched: Update rq clock on tickless CPUs before calling check_preempt_curr() Frederic Weisbecker
2012-12-29 16:42 ` Frederic Weisbecker [this message]
2012-12-29 16:42 ` [PATCH 16/27] sched: Update clock of nohz busiest rq before balancing Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 17/27] sched: Update rq clock before idle balancing Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 18/27] sched: Update nohz rq clock before searching busiest group on load balancing Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 19/27] nohz: Move nohz load balancer selection into idle logic Frederic Weisbecker
2012-12-29 16:42 ` [PATCH 20/27] nohz: Full dynticks mode Frederic Weisbecker
2012-12-29 16:43 ` [PATCH 21/27] nohz: Only stop the tick on RCU nocb CPUs Frederic Weisbecker
2013-01-02  8:47   ` Namhyung Kim
2013-01-04 12:53     ` Frederic Weisbecker
2012-12-29 16:43 ` [PATCH 22/27] nohz: Don't turn off the tick if rcu needs it Frederic Weisbecker
2012-12-29 16:43 ` [PATCH 23/27] nohz: Don't stop the tick if posix cpu timers are running Frederic Weisbecker
2012-12-29 16:43 ` [PATCH 24/27] nohz: Add some tracing Frederic Weisbecker
2012-12-29 16:43 ` [PATCH 25/27] rcu: Don't keep the tick for RCU while in userspace Frederic Weisbecker
2012-12-29 16:43 ` [PATCH 26/27] profiling: Remove unused timer hook Frederic Weisbecker
2012-12-29 16:43 ` [PATCH 27/27] timer: Don't run non-pinned timer to full dynticks CPUs Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1356799386-4212-16-git-send-email-fweisbec@gmail.com \
    --to=fweisbec@gmail.com \
    --cc=abogani@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=cmetcalf@tilera.com \
    --cc=geoff@infradead.org \
    --cc=gilad@benyossef.com \
    --cc=hakanakkan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).